-
-
Notifications
You must be signed in to change notification settings - Fork 298
refactor(bump): eliminate similar patterns in code #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bump): eliminate similar patterns in code #1508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## refactors #1508 +/- ## ============================================= + Coverage 97.87% 97.90% +0.03% ============================================= Files 57 57 Lines 2677 2673 -4 ============================================= - Hits 2620 2617 -3 + Misses 57 56 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
commitizen/commands/bump.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a bit easier to read 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc getattr does not have good type annotation. I prefer the following and still easy to read.
out_func = out.diagnostic if self.git_output_to_stderr else out.write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
b7b9066 to
b836c9e
Compare
a92edf3 to
baa0224
Compare
baa0224 to
99bd410
Compare
Uh oh!
There was an error while loading. Please reload this page.
Description
Checklist