Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

refactor(git): simplify tag logic #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:refactors from bearomorphism:refactor-tag
Jun 8, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented Jun 5, 2025 •
edited
Loading

Description

Checklist

@bearomorphism bearomorphism marked this pull request as ready for review June 5, 2025 18:06
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good, one nitpick

# we're not able to create lightweight tag with message.
# by adding message, we make it a annotated tags
return cmd.run(f'git tag {_opt} "{tag if _opt == "" or msg is None else msg}"')
option = "-s" if signed else "-a"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth mentione the else case if for annotated

Copy link
Contributor Author

@bearomorphism bearomorphism Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment.

@Lee-W Lee-W added this to the 4.8.3 milestone Jun 8, 2025
@Lee-W Lee-W added the pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check label Jun 8, 2025
Copy link

codecov bot commented Jun 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (a9cd957) to head (a505d5b).
Report is 2 commits behind head on refactors.

Additional details and impacted files 
@@ Coverage Diff @@
## refactors #1507 +/- ##
=============================================
- Coverage 97.87% 97.86% -0.01% 
=============================================
 Files 57 57 
 Lines 2677 2675 -2 
=============================================
- Hits 2620 2618 -2 
 Misses 57 57
Flag Coverage Δ
unittests 97.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W merged commit 542d46b into commitizen-tools:refactors Jun 8, 2025
18 checks passed
@bearomorphism bearomorphism deleted the refactor-tag branch June 13, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review type: refactor
Projects
None yet
Milestone
4.8.3
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /