refactor(bump): simplify nested if #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lee-W merged 1 commit into commitizen-tools:refactors from bearomorphism:bump-if-refactor

Jun 8, 2025

Merged

refactor(bump): simplify nested if #1505

Lee-W merged 1 commit into commitizen-tools:refactors from bearomorphism:bump-if-refactor

Jun 8, 2025

Conversation

bearomorphism

Copy link

Contributor

@bearomorphism bearomorphism commented Jun 5, 2025

Wait for #1466

Description

Checklist

I have read the contributing guidelines

Code Changes

Add test cases to all the changes you introduce
Run poetry all locally to ensure this change passes linter check and tests
Manually test the changes:
- Verify the feature/bug fix works as expected in real-world scenarios
- Test edge cases and error conditions
- Ensure backward compatibility is maintained
- Document any manual testing steps performed
Update the documentation for the changes

Documentation Changes

Run poetry doc locally to ensure the documentation pages renders correctly
Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:
INFO - Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@github-actions github-actions bot added pr-status: wait-for-review type: refactor labels

Jun 5, 2025

@codecov Codecov

Copy link

codecov bot commented Jun 5, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (a9cd957) to head (210ff51).
Report is 4 commits behind head on refactors.

Additional details and impacted files

@@ Coverage Diff @@
## refactors #1505 +/- ##
=============================================
- Coverage 97.87% 97.86% -0.01% 
=============================================
 Files 57 57 
 Lines 2677 2675 -2 
=============================================
- Hits 2620 2618 -2 
 Misses 57 57