Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

refactor(conventional_commits): make schema_pattern more readable #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:refactors from bearomorphism:pattern
Jun 8, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented May 30, 2025 •
edited
Loading

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Expected Behavior

Steps to Test This Pull Request

Run cz check --message "blahblahblah" multiple times to check if it's working as expected. We don't use capture groups of re.compile(self.schema_pattern) so it's fine to adjust the parentheses.

Additional Context

Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (a9cd957) to head (cdec1a0).
Report is 10 commits behind head on refactors.

Additional details and impacted files 
@@ Coverage Diff @@
## refactors #1469 +/- ##
==========================================
 Coverage 97.87% 97.87% 
==========================================
 Files 57 57 
 Lines 2677 2678 +1 
==========================================
+ Hits 2620 2621 +1 
 Misses 57 57
Flag Coverage Δ
unittests 97.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism marked this pull request as ready for review May 30, 2025 04:43
@Lee-W Lee-W added this to the 4.8.3 milestone May 31, 2025
@Lee-W Lee-W marked this pull request as draft June 8, 2025 08:20
Copy link
Member

Lee-W commented Jun 8, 2025

Oh... no wonder there are so many codes I think I have read. would need you help to resolve the conflict

@Lee-W Lee-W force-pushed the refactors branch 2 times, most recently from baee83e to a9cd957 Compare June 8, 2025 13:31
super().__init__()
self.is_empty_config = False
self.add_path(path)
self.path=path# type: ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the type ignore here?

@Lee-W Lee-W merged commit 965f34e into commitizen-tools:refactors Jun 8, 2025
18 checks passed
@bearomorphism bearomorphism deleted the pattern branch June 12, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Projects
None yet
Milestone
4.8.3
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /