Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

docs(taplo): add toml formatter #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 2 commits into commitizen-tools:v4-9-0-test from bearomorphism:toml-formatter
Jun 14, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented May 25, 2025 •
edited
Loading

Description

I noticed that I accidentally introduced unexpected style change in pyproject.toml (50fd65f), so I think it would be better if we have a consistent toml formatter.

Checklist

Code Changes

  • Update the documentation for the changes

Expected Behavior

Pre-commit hook now has taplo and it should work even without installing taplo locally.

Steps to Test This Pull Request

  1. Randomly insert white spaces in pyproject.toml and save without formatting to make the formatting bad.
  2. git commit
  3. The broken format should be fixed.

Additional Context

https://taplo.tamasfe.dev/configuration/formatter-options.html

Copy link

codecov bot commented May 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4-9-0-test@6a90185). Learn more about missing BASE report.

Additional details and impacted files 
@@ Coverage Diff @@
## v4-9-0-test #1456 +/- ##
==============================================
 Coverage ? 97.98% 
==============================================
 Files ? 58 
 Lines ? 2685 
 Branches ? 0 
==============================================
 Hits ? 2631 
 Misses ? 54 
 Partials ? 0
Flag Coverage Δ
unittests 97.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism marked this pull request as ready for review May 25, 2025 12:34
@bearomorphism bearomorphism force-pushed the toml-formatter branch 3 times, most recently from 261a106 to 2d56a80 Compare May 25, 2025 14:06
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this one, but I will let @woile or @noirbizarre decide whether we need it.

bearomorphism reacted with thumbs up emoji
@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 25, 2025
@bearomorphism bearomorphism changed the base branch from master to v4-9-0-test June 14, 2025 03:38
Copy link
Member

Lee-W commented Jun 14, 2025

as no objections for a few weeks, I'll go ahead and merge it

@Lee-W Lee-W merged commit d9f5b49 into commitizen-tools:v4-9-0-test Jun 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /