Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

refactor(check): remove unnecessary list construction #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented May 25, 2025 •
edited
Loading

Description

Checklist

Code Changes

  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed

Expected Behavior

Steps to Test This Pull Request

Additional Context

Copy link

codecov bot commented May 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (120d514) to head (9860776).
Report is 655 commits behind head on master.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1455 +/- ##
==========================================
+ Coverage 97.33% 97.62% +0.28% 
==========================================
 Files 42 57 +15 
 Lines 2104 2650 +546 
==========================================
+ Hits 2048 2587 +539 
- Misses 56 63 +7
Flag Coverage Δ
unittests 97.62% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W changed the base branch from master to refactors May 25, 2025 14:35
@Lee-W Lee-W changed the base branch from refactors to master May 25, 2025 14:36
self._valid_command_argument()

self.config: BaseConfig = config
self.config = config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we remove it?

if not line.startswith("#"):
lines.append(line)
return "\n".join(lines)
msg_lines = msg.split("\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether we want to do this. Look like we'll loop through lines twice and the logic looks more complicated

Copy link
Contributor Author

I'm closing this one. This does not make it more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W left review comments

@woile woile Awaiting requested review from woile woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /