Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

build(termcolor): remove termcolor <3 restriction #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 2 commits into commitizen-tools:refactors from bearomorphism:termcolor-upgrade
May 27, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented May 23, 2025 •
edited
Loading

Closes #1420

Description

Checklist

Additional Context

https://github.com/termcolor/termcolor/releases

Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (856ca4f) to head (7af56c6).
Report is 3 commits behind head on refactors.

Additional details and impacted files 
@@ Coverage Diff @@
## refactors #1450 +/- ##
=============================================
- Coverage 97.78% 97.78% -0.01% 
=============================================
 Files 57 57 
 Lines 2620 2617 -3 
=============================================
- Hits 2562 2559 -3 
 Misses 58 58
Flag Coverage Δ
unittests 97.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

I'm now using commitizen with termcolor 3.1.0 and it looks good so far.

@Lee-W Lee-W changed the base branch from master to refactors May 24, 2025 03:21
@Lee-W Lee-W changed the base branch from refactors to master May 24, 2025 03:21
@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 24, 2025
@Lee-W Lee-W changed the base branch from master to refactors May 25, 2025 14:30
@Lee-W Lee-W force-pushed the termcolor-upgrade branch from 996650e to b0d8901 Compare May 25, 2025 14:35
Copy link
Member

Lee-W commented May 25, 2025

@bearomorphism I tried to rebased it on the latest refactors branch. It seems to break the tests somehow 🤔
bearomorphism reacted with confused emoji

Copy link
Contributor Author

It happens sometime. I'll try to trigger the checks again.

Copy link
Member

Lee-W commented May 25, 2025

I actaully triggered but it still failed 🤔

Copy link
Contributor Author

sounds weird.

Copy link
Contributor Author

https://pypi.org/project/termcolor/

termcolor says it supports python 3.9?

Copy link
Member

Lee-W commented May 25, 2025

looks like so 🤔

Copy link
Contributor Author

let me try it with python 3.9 on my machine

Copy link
Contributor Author

IIRC build does not bump version, so we can make the target branch master?

Copy link
Contributor Author

I suspect some dependency broke the test when using termcolor 3

Copy link
Contributor Author

importlib-metadata

Copy link
Contributor Author

importlib-metadata@8.7.0 + python@3.9 breaks the test

Copy link
Contributor Author

@bearomorphism I tried to rebased it on the latest refactors branch. It seems to break the tests somehow 🤔

fixed

@bearomorphism bearomorphism force-pushed the termcolor-upgrade branch 3 times, most recently from 0623dd5 to 4b99435 Compare May 25, 2025 16:06
pyproject.toml Outdated
@@ -23,8 +23,8 @@ dependencies = [
"typing-extensions (>=4.0.1,<5.0.0) ; python_version < '3.11'",
"charset-normalizer (>=2.1.0,<4)",
# Use the Python 3.11 and 3.12 compatible API: https://github.com/python/importlib_metadata#compatibility
"importlib_metadata (>=8.0.0,<9) ; python_version < '3.10'",

"importlib-metadata >=8.0.0,<8.7.0 ; python_version < '3.10'", # importlib-metadata@8.7.0 + python3.9 breaks our unit test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably could use != for 3.9 and still use >=8.0.0,<9.0.0 for others

bearomorphism reacted with thumbs up emoji
@bearomorphism bearomorphism force-pushed the termcolor-upgrade branch 2 times, most recently from e24e833 to 7af56c6 Compare May 26, 2025 01:55
@Lee-W Lee-W merged commit 2259b3a into commitizen-tools:refactors May 27, 2025
@bearomorphism bearomorphism deleted the termcolor-upgrade branch June 1, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support termcolor version 3

AltStyle によって変換されたページ (->オリジナル) /