Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(defaults): add non-capitalized default constants back and deprecated warning #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:refactors from bearomorphism:fix-defaults
May 25, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented May 22, 2025 •
edited
Loading

relates: #1446

Description

Related commit: 94c02b3#diff-c951de16d627d82e01eb3ce8d7c4f0b28973ffe147520620762e7140ede2dd80

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@a8094ae). Learn more about missing BASE report.

Additional details and impacted files 
@@ Coverage Diff @@
## refactors #1447 +/- ##
============================================
 Coverage ? 97.63% 
============================================
 Files ? 57 
 Lines ? 2661 
 Branches ? 0 
============================================
 Hits ? 2598 
 Misses ? 63 
 Partials ? 0
Flag Coverage Δ
unittests 97.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W changed the title (削除) fix(defaults): add non-capitalized default constants back and depreca... (削除ここまで) (追記) fix(defaults): add non-capitalized default constants back and deprecated warning (追記ここまで) May 23, 2025
Copy link
Member

Lee-W commented May 23, 2025

This PR won't close #1446. That one is more like a discussion on how we decide to bump a major verison or not (e.g., some private method can be changed whatever we want, while public ones we might not want it to be that way), Thus changed the description to relates
bearomorphism reacted with thumbs up emoji

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nits. over all looks good!

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 23, 2025
@Lee-W Lee-W changed the base branch from master to refactors May 25, 2025 14:33
@Lee-W Lee-W merged commit 0c811f8 into commitizen-tools:refactors May 25, 2025
18 checks passed
@bearomorphism bearomorphism deleted the fix-defaults branch June 1, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /