-
-
Notifications
You must be signed in to change notification settings - Fork 301
docs: Revert removal of escape in monorepo toml example #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@baluyotraf
baluyotraf
requested review from
woile,
Lee-W and
noirbizarre
as code owners
May 6, 2025 13:49
Lee-W
Lee-W
approved these changes
May 6, 2025
woile
woile
approved these changes
May 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1401 +/- ## ========================================== + Coverage 97.33% 97.55% +0.21% ========================================== Files 42 57 +15 Lines 2104 2656 +552 ========================================== + Hits 2048 2591 +543 - Misses 56 65 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Sorry I messed up, I forgot that you're required to escape the
\in TOML. See #1398. I should have not removed it. Though the example should still be fixed so I'm only reverting the escapes. I'm really sorry D:.Checklist
poetry alllocally to ensure this change passes linter check and testExpected behavior
TOML requires
\to be escaped as\\Steps to Test This Pull Request
Additional context