-
-
Notifications
You must be signed in to change notification settings - Fork 298
fixes yaml example #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes yaml example #1350
Conversation
Description
Fixes documentation typos.
Checklist
* [ ] ~Add test cases to all the changes you introduce~ * [ ] ~Run `./scripts/format` and `./scripts/test` locally to ensure this change passes linter check and test~ * [ ] ~Test the changes on the local machine manually~ * [x] Update the documentation for the changesExpected behavior
n/A
Steps to Test This Pull Request
n/A
Additional context
n/A
Hi, thanks for fixing the typo. we need to follow the commit rule to pass the CI. could you please modify it? thanks!
ecf51a9 to
2e22ed9
Compare
Like this @Lee-W ?
hmm... I am not sure what you changed. but I can take over and fix the commit issue. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1350 +/- ## ========================================== + Coverage 97.33% 97.55% +0.21% ========================================== Files 42 55 +13 Lines 2104 2614 +510 ========================================== + Hits 2048 2550 +502 - Misses 56 64 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hmm... I am not sure what you changed. but I can take over and fix the commit issue. Thanks!
Thank you. I see, my commit message was still wrong!
I'm new to this project and just tried and played around. I found these typos and just quickly fixed them using Githubs UI. I were unable to identify any contribution guidelines (either by CONTRIBUTING.md nor documentation) easily. @Lee-W are there any contribution guidelines highlighting this?
hmm... I am not sure what you changed. but I can take over and fix the commit issue. Thanks!
Thank you. I see, my commit message was still wrong!
I'm new to this project and just tried and played around. I found these typos and just quickly fixed them using Githubs UI. I were unable to identify any contribution guidelines (either by CONTRIBUTING.md nor documentation) easily. @Lee-W are there any contribution guidelines highlighting this?
No worries 🙂 Yep, it's in the docs https://commitizen-tools.github.io/commitizen/contributing/
Uh oh!
There was an error while loading. Please reload this page.
Description
Fixes documentation typos.
Checklist
(削除) Add test cases to all the changes you introduce (削除ここまで)(削除) Run./scripts/formatand./scripts/testlocally to ensure this change passes linter check and test (削除ここまで)(削除) Test the changes on the local machine manually (削除ここまで)Expected behavior
n/A
Steps to Test This Pull Request
n/A
Additional context
n/A