-
-
Notifications
You must be signed in to change notification settings - Fork 301
Improve hooks type annotation and fix missing link #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1345 +/- ## ========================================== + Coverage 97.33% 97.58% +0.25% ========================================== Files 42 55 +13 Lines 2104 2614 +510 ========================================== + Hits 2048 2551 +503 - Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Note for later:
- we should also provide them as pre-commit hook
- maybe we should have a
cz hook installor something like that to avoid the manual fetch with curl
👍🏼
Note for later:
* we should also provide them as pre-commit hook * maybe we should have a `cz hook install` or something like that to avoid the manual fetch with curl
Yep, I was thinking about that as well (but not yet have time 🥲). added an issue #1355 to track this
Description
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Everything should still be the same
Steps to Test This Pull Request
None
Additional context