-
-
Notifications
You must be signed in to change notification settings - Fork 298
Feature/multi language commitizen #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multi language commitizen #1328
Conversation
...isplay informations this is just a first version that is not yet efficient and must be implemented to be more efficient
egstion des differnts porbleme, il faut encore gerer les tests
corrcet the part of code that do not matched
J ai corrige le format de cz afin d y introduire le langage BREAKING CHANGE:
test to be sure that all the case are looked. The language option give the oppotunity to choose on wich language you want to display infomation during the commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you should review : https://github.com/commitizen-tools/commitizen/pull/1328/files. This is the last version and I think that it must work perfectly.
Got it. In that case, I'll close this one
opps, close the wrong one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have one file per language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to exclude it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we ignore errors?
As there're many changes needed, convert it to draft.
I'll close this one as we might need more discussion before actually implementing it. Feel free to raise a discussion anytime 🙂
Uh oh!
There was an error while loading. Please reload this page.
Description
As I said previously I made mistakes with the .github that I removed by mistake. I think that now the feature may work perfectly, I hope so in fact. If there is somme issues, please say it to me. You can easily add new languages but the most common languages are here.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
I think that this feature is a way to make this extension a way most powerful and more useful for everyone.
Steps to Test This Pull Request
poetry installpoetry shellgit add .python3.X commitizen/__main__.py -language fr commitherefris just an example you can put any format.Xmust be changed with the version you are using.czin it is in production :cz -language fr commitAdditional context
It must be good for the main part