-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat(commands/commit): add manual-edit functionality after answering questions #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 1 commit into
commitizen-tools:master
from
josix:feat/commit/allow-force-edit-after-prompting
Oct 23, 2024
Merged
feat(commands/commit): add manual-edit functionality after answering questions #1262
Lee-W
merged 1 commit into
commitizen-tools:master
from
josix:feat/commit/allow-force-edit-after-prompting
Oct 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #1262 +/- ## ========================================== + Coverage 97.33% 97.61% +0.27% ========================================== Files 42 55 +13 Lines 2104 2602 +498 ========================================== + Hits 2048 2540 +492 - Misses 56 62 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@josix
josix
force-pushed
the
feat/commit/allow-force-edit-after-prompting
branch
4 times, most recently
from
October 15, 2024 12:24
30409a4 to
9898d3e
Compare
@josix
josix
requested review from
woile,
Lee-W and
noirbizarre
as code owners
October 15, 2024 12:28
Lee-W
Lee-W
reviewed
Oct 16, 2024
.../commands/test_commit_command/test_commit_command_shows_description_when_use_help_option.txt
Show resolved
Hide resolved
@josix
josix
changed the title
(削除) feat(commands/commit): add force-edit functionality after answering questions (削除ここまで)
(追記) feat(commands/commit): add manual-edit functionality after answering questions (追記ここまで)
Oct 16, 2024
@josix
josix
force-pushed
the
feat/commit/allow-force-edit-after-prompting
branch
from
October 16, 2024 03:32
0142443 to
9b42049
Compare
Lee-W
Lee-W
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one nit, but mostly looks good!
@Lee-W
Lee-W
added
pr-status: ready-to-merge
almost ready to merge. just keep it for a few days for others to check
and removed
pr-status: wait-for-review
labels
Oct 20, 2024
...uestions refactor: remove redundant return None Co-authored-by: Wei Lee <weilee.rx@gmail.com> Update test_commit_command.py Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@josix
josix
force-pushed
the
feat/commit/allow-force-edit-after-prompting
branch
2 times, most recently
from
October 21, 2024 02:41
f73d452 to
513f86a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Add one argument
-e/--editto commit command, to allow user to continue editing after filling up all the questions.(Kudos to @MrMino! The
pytest-editproject inspired me to come up with this idea.)Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
if
-e/--editenabled, the terminal would pop up editor with commit message after finishing the answering.Steps to Test This Pull Request
cz c -e