-
-
Notifications
You must be signed in to change notification settings - Fork 301
Look up config in git root #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
woile
merged 12 commits into
commitizen-tools:master
from
Lee-W:look-up-config-in-git-root
Jan 20, 2020
Merged
Look up config in git root #123
woile
merged 12 commits into
commitizen-tools:master
from
Lee-W:look-up-config-in-git-root
Jan 20, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's not used in base_config but should be overwritten in a child class
...it project
pathlib returns Path('.') if empty is passed
Looks good, I'm on holiday now, coming weekend I'll check it in depth
Sure! I might send a few PRs these days. But take your time and have a nice holiday 🎉
@Lee-W
Lee-W
force-pushed
the
look-up-config-in-git-root
branch
from
January 17, 2020 11:13
ef9ac10 to
84a2118
Compare
woile
woile
reviewed
Jan 20, 2020
global_cfg = os.path.join(home, ".cz")
if not os.path.exists(global_cfg):
home = Path.home()
global_cfg = home/Path(".cz")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.