-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat: enable --prerelease none for CI/CD #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dmyersturnbull
dmyersturnbull
requested review from
woile,
Lee-W and
noirbizarre
as code owners
June 17, 2024 14:42
@dmyersturnbull
dmyersturnbull
changed the title
(削除) master (削除ここまで)
(追記) feat: enable --prerelease none for CI/CD (追記ここまで)
Jun 17, 2024
It sounds like a good improvement to me, but we will need your help to get a CI pass before we can do a thoughtful review. Thanks!
Thanks for the reply. I'll get to this! I was just surprised that the tests failed and didn't immediately have time to fix it.
@Lee-W
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry for not creating an issue first, but I figured the change was so easy to make.
--prerelease none
When using the GitHub Action, users will probably want to set
--prerelease
either dynamically or from a dispatch parameter. Without this, redundantcommitizen-action
calls are needed; e.g.:StrEnum
While at it, I also converted
Increment
andPrerelease
intoStrEnum
s, which should be helpful in an IDE. I violated the convention of ALL_CAPS forPrerelease
for consistency, but I'm happy to change it.Edit:
gh pr create --fill
did something weird!