-
-
Notifications
You must be signed in to change notification settings - Fork 297
test(git): add a test for handling blank with path in git commit #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #1044 +/- ## ========================================== + Coverage 97.33% 97.48% +0.15% ========================================== Files 42 55 +13 Lines 2104 2429 +325 ========================================== + Hits 2048 2368 +320 - Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As this has no update since last year and there might be lots of conflicts, I'm going to close this one. Feel free to reopen it, if we still want this improvement in 🙂
related: #572
Description
add-a-test-for-handling-blank-with-path-in-git-commit
Whether the path includes blank or not, the git commit action can parse anyway and correctly execute
commitunder commitizen/commitizen/git.py and go through the util functioncreate_file_and_commitChecklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
if the project path is including blank, the program should work.
Steps to Test This Pull Request
run
./scripts/testor run the single texttest_git_commit_command_with_varied_paths_handles_blankundertests/test_git.py