-
Notifications
You must be signed in to change notification settings - Fork 42
Add GPG Signing Support #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add input for GPG key and passphrase and whether or not to sign.
Add `-s` to `bump` command if `gpg_sign` is 'true'.
@woile Would you please kindly review? Thank you!
Set `gpg.program`, `commit.gpgsign`, and `tag.gpgsign`.
Git requires `signingkey` to sign commits and tags.
Git takes the UID for the signing key, not the key itself.
Add `gpg.program` to Git config.
Use bash script to configure the GPG agent, import keys, set the passphrase, and configure Git.
Use `service` as `systemctl` is not on GitHub Actions runners.
This reverts commit 2cf68aa.
This reverts commit a1c8571.
This reverts commit 94d316f.
Only sign tags. It may be that `commitizen` only supports signing tags. See: commitizen-tools/commitizen#616
Remove `tag.gpgsign` and `commit.gpgsign` from local Git config.
See if Git will sign for us instead of through `cz`.
Remove specifying `gpg.program` and add `commit.gpgsign` back.
Add `--gpg-sign` back to `commitizen`.
Switch `--gpg-sign` applies to `bump` subcommand.
Move `--debug` switch to after `bump` command.
This reverts commit e543aff.
This reverts commit 3b2cae5.
woile
woile
approved these changes
Jan 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry for the delay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for GPG signing.
Closes: #50