-
Notifications
You must be signed in to change notification settings - Fork 3k
Open
Conversation
nodeMajor === 25 — turboshaft bug only exist 25.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Node/Vitest/test infrastructure to avoid known Node 25 issues while enabling Node 26+, and stabilizes MCP-related integration tests/CI.
Changes:
- Adjust Node version gating to block only Node 25 at runtime and allow Node 26+ via
engines. - Add a Vitest forks
execArgvworkaround for a Node 22–25 V8 WASM crash. - Stabilize MCP server tests (disable relaunch; await child shutdown) and add a CI workflow matrix for Node 24/26 on Linux/macOS.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Adds conditional worker execArgv to work around a Node/V8 WASM crash in affected majors. |
| src/bin/codegraph.ts | Narrows runtime "unsafe Node" block to Node 25 only. |
| package.json | Updates engines.node to permit Node 26+ while excluding Node 25. |
| tests/mcp-roots.test.ts | Prevents server relaunch in tests; awaits child process shutdown in teardown. |
| tests/mcp-initialize.test.ts | Prevents server relaunch in tests; awaits child process shutdown in teardown. |
| .github/workflows/CI.yml | Introduces CI workflow running build+tests on Node 24 and 26 for Linux/macOS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
include: ['__tests__/**/*.test.ts'],
poolOptions: {
forks: {
execArgv: NEEDS_LIFTOFF_ONLY ? ['--liftoff-only'] : [],
Comment on lines
+88
to
+93
afterEach(async () => {
if (child) {
if (!child.killed) child.kill('SIGKILL');
if (child.exitCode === null) {
await new Promise<void>(resolve => child!.once('close', resolve));
}
Comment on lines
+103
to
+108
afterEach(async () => {
if (child) {
if (!child.killed) child.kill('SIGKILL');
if (child.exitCode === null) {
await new Promise<void>(resolve => child!.once('close', resolve));
}
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest] # windows-latest
node-version: [24, 26]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
all test are passed: https://github.com/kongdd/codegraph/actions/runs/26364537847
image