Add positional options support #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

marcrittinghaus wants to merge 1 commit into cofyc:master

from marcrittinghaus:mritting/pr_positional_options

Open

Add positional options support #61

marcrittinghaus wants to merge 1 commit into cofyc:master from marcrittinghaus:mritting/pr_positional_options

Conversation

@marcrittinghaus

Copy link

@marcrittinghaus marcrittinghaus commented Dec 28, 2022

Currently, positional options are not explicitly supported but just remain as unparsed arguments. This commit adds support for positional arguments so that these are treated like other options including parsing and listing in the help output.

Positional arguments can be defined as regular options but with the OPT_POSITIONAL flag:

 OPT_GROUP("Positional options"),
 OPT_INTEGER(0, "posi", &posi, "positional integer", NULL, 0, OPT_POSITIONAL),
 OPT_STRING(0, "poss", &poss, "positional string", NULL, 0, OPT_POSITIONAL),

The long name is used in error messages if the argument cannot be parsed.

This PR addresses issue: #46

@marcrittinghaus


 Add positional options support

a0641cb

Currently, positional options are not explicitly supported but just
remain as unparsed arguments. This commit adds support for positional
arguments so that these are treated like other options including
parsing and listing in the help output.
Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io>

@cofyc-bot

Copy link

Collaborator

cofyc-bot commented Dec 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcrittinghaus
To complete the pull request process, please assign cofyc
You can assign the PR to them by writing /assign @cofyc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files: