-
-
Notifications
You must be signed in to change notification settings - Fork 608
Fix for issue 105 -- more robust IP and hostname validation #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New commits
New commits 4-19
...input by the user.
Stale pull request message
drwetter
commented
Sep 1, 2020
Why the F^Wheck was this automatically closed?
Wondering whether this project is still maintained.
Clearly I wasn't quick enough with my edit to avoid getting auto closed.
He did respond to one of my other threads though @drwetter, I think he's busy but getting to them slowly but surely.
drwetter
commented
Sep 1, 2020
Ok but why is the bot enabled if he/she cannot get to it atm?
drwetter
commented
Oct 27, 2020
Is this project still alive?
Doesn't look like it @drwetter. It can always be reopened if the maintainer wants this PR, but I'm not going to worry about it anymore until that happens.
Uh oh!
There was an error while loading. Please reload this page.
Added a regex to look for hostname and IPV4 patterns. If this first check passes, then the
ipaddressmodule from the standard library is used to validate the IP address. If a hostname is detected instead of an IP address, it will try to get the fully qualified domain name. Keeping within the standard library,socket.getfqdnwas used for this step. Let me know if you think the FQDN part might be overkill.I added this for options 1 and 7, which prompt the user for an IP address or domain. I left out the domain part for option 7.
Edit to remove stale tag.