-
-
Notifications
You must be signed in to change notification settings - Fork 12
ADD CSS variables #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed the hard coded values to modern CSS variables in a central place and reused them for ease of use. Tried to balance consistency with existing values, minute pixel changes can result from this change.
Hi David,
Thanks again for your shared code, We are using it to exapnd our own library and are very grateful. We changed the theme a bit and we did that with these css variables to make that easier. I am also planning to create a themed version with more changes but that would not be so backward compatible so I left "most" values in this commit the same as your original example. The changes should be small enough so that nothing breaks.
Changed the hard coded values to modern CSS variables in a central place and reused them for ease of use. Tried to balance consistency with existing values, minute pixel changes can result from this change.