-
Notifications
You must be signed in to change notification settings - Fork 935
fix: improve empty repository URL error #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2c9ec2 to
e0ec14f
Compare
⚙️ Preview environment was undeployed.
e0ec14f to
54da8e1
Compare
Hello, and thank you for your PR!
The returned error should be the same as what we have for invalid repository URL so that the front-end can display them properly
url 'https://pr-454.gitingest.coderamp.dev/api/ingest' \
-X POST \
-H 'Content-Type: application/json' \
--data-raw '{"input_text":" ","token":"","max_file_size":"243","pattern_type":"exclude","pattern":""}'
{"detail":[{"type":"value_error","loc":["body","input_text"],"msg":"Value error, input_text cannot be empty","input":" ","ctx":{"error":{}}}]}
curl 'https://pr-454.gitingest.coderamp.dev/api/ingest' \
-X POST \
-H 'Content-Type: application/json' \
--data-raw '{"input_text":"agaga","token":"","max_file_size":"243","pattern_type":"exclude","pattern":""}'
{"error":"Invalid repository URL 'agaga'"}
It returns:
{"error": "Invalid repository URL: cannot be empty or spaces only."}
and it works correctly in the frontend
Hi there! We haven’t seen activity on this pull request for 45 days, so I’m marking it as stale.
If you’d like to keep it open, please leave a comment within 10 days. Thanks!
Fixes #453
Summary
This PR fixes a bug where a single space (" ") as
input_textcaused an empty digest response.{"error": "Invalid repository URL: cannot be empty or spaces only."}.