-
Notifications
You must be signed in to change notification settings - Fork 892
fix: improve empty repository URL error #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MickaelCa
MickaelCa
force-pushed
the
fix-empty-url
branch
from
July 26, 2025 23:13
b2c9ec2 to
e0ec14f
Compare
⚙️ Preview environment was undeployed.
@MickaelCa
MickaelCa
force-pushed
the
fix-empty-url
branch
from
July 26, 2025 23:15
e0ec14f to
54da8e1
Compare
Hello, and thank you for your PR!
The returned error should be the same as what we have for invalid repository URL so that the front-end can display them properly
url 'https://pr-454.gitingest.coderamp.dev/api/ingest' \
-X POST \
-H 'Content-Type: application/json' \
--data-raw '{"input_text":" ","token":"","max_file_size":"243","pattern_type":"exclude","pattern":""}'
{"detail":[{"type":"value_error","loc":["body","input_text"],"msg":"Value error, input_text cannot be empty","input":" ","ctx":{"error":{}}}]}
curl 'https://pr-454.gitingest.coderamp.dev/api/ingest' \
-X POST \
-H 'Content-Type: application/json' \
--data-raw '{"input_text":"agaga","token":"","max_file_size":"243","pattern_type":"exclude","pattern":""}'
{"error":"Invalid repository URL 'agaga'"}
It returns:
{"error": "Invalid repository URL: cannot be empty or spaces only."}
and it works correctly in the frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453
Summary
This PR fixes a bug where a single space (" ") as
input_textcaused an empty digest response.{"error": "Invalid repository URL: cannot be empty or spaces only."}.