Hey again @ix-56h, I was able to make some hot fixes to my original additions.

Regarding the merge of #427 , do you want me to modify max_file_size to reflect the upcoming typing restriction from str to int? Or should I wait after you and @filipchristiansen merge #427.

Furthermore. since this is my first time contributing to an open source, I'm going to ask a lot of clarifying questions to help me contribute better!

I need some direction/guidance on how to "create a dedicated repo with weird stuff to make specific testing." Any advice on how to begin doing this? I figured I'd start on this dedicated repo after I finished polishing up the rest of the test files that are listed as priority

I'll wait on modifying test_git_utils.py for now until the first two files are all good.

Hey @ix-56h, I believe test_flow_integration.py and test_ingestion.py are all good now. Let me know if you think of any other specific/weird tests I can add on.

I also added a few test cases to test_git_utils.py for you to review.

The modified test files should be good to go now, I think it's ready to be merged with main.

This pull request has merge conflicts that must be resolved before it can be merged.

Hey @ix-56h, it's saying that I have merge conflicts in test_flow_integration.py, but I'm looking at the file right now and I see none at all, can you figure out why it's bugging out? Thanks man.

Done @fritznastor

This pull request has resolved merge conflicts and is ready for review.

Hey @filipchristiansen, do you think you can check this out real quick, I appreciate it!

Hey @filipchristiansen, do you think you can check this out real quick, I appreciate it!

I'm away on Iceland until early next week, maybe @NicolasIRAGNE can have a look at it?

Hey @NicolasIRAGNE, do you have some time to check out my changes!

Hello @fritznastor !
sorry for the time I took to answer -- I've been a bit busy these days.

Thanks a lot for the PR -- unfortunately, I think this is not the direction we want to take for tests and they need a major, if not complete rewrite.

There needs to be no external calls at all, otherwise they're unreliable and may cause errors based on external factors (which is currently happening pretty often in current CI)

Hey @NicolasIRAGNE , thanks for getting back to me, @ix-56h thought that my updates to the test suite were pretty good, do you mind explaining more about what I should do?

Specifically:
Should I be mocking all external repo access and simulating Git responses instead of using real repos like flask or vscode?

Is there an internal fixture or preferred test structure you'd like me to follow when testing edge cases like binary files, symlinks, etc.?

Lastly, would it be more helpful for me to focus on unit tests with mocked I/O rather than higher-level integration scenarios?

I’m happy to do a rewrite that better fits the project’s goals—I want to make sure I’m going about it the right way.

This pull request has merge conflicts that must be resolved before it can be merged.

Hi there! We haven’t seen activity on this pull request for 45 days, so I’m marking it as stale.
If you’d like to keep it open, please leave a comment within 10 days. Thanks!