-
Notifications
You must be signed in to change notification settings - Fork 0
Switch production EKS to t3 instances for compatibility #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,8 @@ inputs = { | |
| public_subnet_ids = dependency.vpc.outputs.public_subnet_ids | ||
| endpoint_public_access = false # Restrict API access for production | ||
|
|
||
| # ARM node group configuration | ||
| arm_instance_types = ["t4g.large", "t4g.xlarge"] | ||
| # Node group configuration - switched to t3 for compatibility | ||
| arm_instance_types = ["t3.large", "t3.xlarge"] | ||
|
Comment on lines
+25
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # First, let's examine the actual file and its context cat -n prod/eks/terragrunt.hcl | head -40 Repository: coderabbitai/rabbits-playground Length of output: 1164 🏁 Script executed: # Search for any exception approvals or justification comments in the repo rg -i "exception|approval|t3.*approved|graviton.*first|instance.*policy" -A 3 -B 3 Repository: coderabbitai/rabbits-playground Length of output: 57 🏁 Script executed: # Look for container image build configuration fd -e Dockerfile -e "*.yml" -e "*.yaml" | head -20 Repository: coderabbitai/rabbits-playground Length of output: 57 🏁 Script executed: # Search for any documentation about instance type policy or requirements rg -i "instance.*type.*policy|graviton.*first|aws.*standard|t3.*prohibited|t4g.*required" -g '*.md' -g '*.txt' -g '*.rst' Repository: coderabbitai/rabbits-playground Length of output: 57 🏁 Script executed: # Check git history for justification of this change git log --oneline -20 --all -- prod/eks/terragrunt.hcl 2>/dev/null || echo "Git history not available" Repository: coderabbitai/rabbits-playground Length of output: 161 🏁 Script executed: # Search for multi-arch or platform-specific image build configuration rg -i "docker buildx|platform.*linux|arm64|amd64|multi.*arch" -g 'Dockerfile*' -g '*.yml' -g '*.yaml' -g '*.sh' | head -30 Repository: coderabbitai/rabbits-playground Length of output: 223 🏁 Script executed: # Check git commit details for the t3 migration git show bfe9a34 --stat 2>/dev/null || echo "Cannot show full commit" Repository: coderabbitai/rabbits-playground Length of output: 2103 🏁 Script executed: # Search for any README or documentation about instance type requirements fd -e README.md -e '*.md' -e '*.txt' | xargs grep -l "instance\|t3\|t4g\|compatibility" 2>/dev/null || echo "No docs found" Repository: coderabbitai/rabbits-playground Length of output: 88 🏁 Script executed: # Check if there are any other node group configurations for comparison rg "instance_types|arm_instance" -B 3 -A 3 Repository: coderabbitai/rabbits-playground Length of output: 1534 🏁 Script executed: # Look for any comments or variables that might explain the compatibility issue rg "compatibility|t3|t4g" --context=5 Repository: coderabbitai/rabbits-playground Length of output: 4258 Critical: Architecture mismatch between AMI type and instance type will cause deployment failures. The change introduces a serious compatibility issue that will prevent the EKS node group from launching successfully:
🤖 Prompt for AI Agents |
||
| arm_desired_size = 3 | ||
| arm_max_size = 10 | ||
| arm_min_size = 3 | ||
|
|
||