-
Notifications
You must be signed in to change notification settings - Fork 6
Markdownlint Showcase #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughA new markdownlint-cli2 configuration file was added to enable specific linting rules and output results in JSON format. A markdown test file with intentional YAML formatting errors was introduced to validate the linting rules and configuration. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai
coderabbitai
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
markdownlint/.markdownlint-cli2.jsonc (1)
2-9
: Trim redundant rule declarations or explicitly enable the rule you’re actually showcasingWith
"default": true
, every core rule (including MD018 that the sample file triggers) is already active. The extra"MD001" ... "MD031"
lines add no functional value and may confuse future maintainers about which rules are really in scope. Either delete them or, if you intend to highlight a subset, drop"default": true
and list only the wanted rules (including MD018).Example minimal config that still exercises all rules:
"outputFormatters": [["markdownlint-cli2-formatter-json"]], - "config": { - "default": true, - "MD001": true, - "MD002": true, - "MD022": true, - "MD031": true - } + "config": { "default": true }markdownlint/test.md (1)
6-7
: Same concern for list spacing and trailing blanksThe missing space after "-" triggers MD030; the trailing spaces trigger MD009. Confirm they remain contained in a dedicated "negative test" area so production docs stay clean.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
markdownlint/.markdownlint-cli2.jsonc
(1 hunks)markdownlint/test.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
markdownlint/test.md
1-1: No space after hash on atx style heading
(MD018, no-missing-space-atx)
2-2: No space after hash on atx style heading
(MD018, no-missing-space-atx)
🔇 Additional comments (2)
markdownlint/.markdownlint-cli2.jsonc (1)
1-10
: Looks good otherwise – valid JSONC and supported formatterThe file parses cleanly and uses the officially-maintained
markdownlint-cli2-formatter-json
, so the basic setup is sound.markdownlint/test.md (1)
1-2
: Flag test file so CI doesn’t fail on purpose-built lint errorsThis file intentionally violates MD018/MD001. Be sure the path is excluded (e.g., via
.markdownlintignore
) or the CI job will red-fail when markdownlint runs in "strict" mode.
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit