-
Notifications
You must be signed in to change notification settings - Fork 6
Preview/Swiftlint #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
reviews: | ||
path_filters: ["**/*","*.*"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix YAML formatting and remove redundant pattern. The configuration has formatting issues and includes a redundant pattern:
Apply this diff to fix the issues: - path_filters: ["**/*","*.*"] + path_filters: ["**/*"] And ensure the file ends with a newline character. 📝 Committable suggestion
Suggested change
path_filters: ["**/*","*.*"]
path_filters: ["**/*"]
🧰 Tools🪛 YAMLlint (1.37.1)[warning] 2-2: too few spaces after comma (commas) [error] 2-2: no new line character at the end of file (new-line-at-end-of-file) 🤖 Prompt for AI Agents
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
disabled_rules: [] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import Foundation | ||
|
||
class my_class { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix class naming to follow Swift conventions. The class name Apply this diff to fix the naming: -class my_class { +class MyClass { 📝 Committable suggestion
Suggested change
class my_class {
class MyClass {
🧰 Tools🪛 SwiftLint (0.57.0)[Error] 3-3: Type name 'my_class' should only contain alphanumeric and other allowed characters (type_name) 🤖 Prompt for AI Agents
|
||
func doSomething( ) { | ||
let name = "ChatGPT" | ||
print( "Hello, \(name)" ) | ||
} | ||
|
||
func unusedFunction() { | ||
// This function is never used | ||
} | ||
Comment on lines
+9
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Remove unused function or mark it appropriately. The Option 1 - Remove the function: - func unusedFunction() { - // This function is never used - } Option 2 - Mark as unavailable if keeping for reference: + @available(*, unavailable, message: "This function is never used")
func unusedFunction() {
// This function is never used
} 📝 Committable suggestion
Suggested change
func unusedFunction() {
// This function is never used
}
Suggested change
func unusedFunction() {
// This function is never used
}
@available(*, unavailable, message: "This function is never used")
func unusedFunction() {
// This function is never used
}
🤖 Prompt for AI Agents
|
||
} | ||
|