-
Notifications
You must be signed in to change notification settings - Fork 6
Preview/eslint #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview/eslint #64
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import globals from "globals"; | ||
| import pluginJs from "@eslint/js"; | ||
| import tseslint from "typescript-eslint"; | ||
| import pluginReactConfig from "eslint-plugin-react/configs/recommended.js"; | ||
| import { fixupConfigRules } from "@eslint/compat"; | ||
|
|
||
|
|
||
| export default [ | ||
| {files: ["**/*.{js,mjs,cjs,ts,jsx,tsx}"]}, | ||
| { languageOptions: { parserOptions: { ecmaFeatures: { jsx: true } } } }, | ||
| {languageOptions: { globals: globals.browser }}, | ||
| pluginJs.configs.recommended, | ||
| ...tseslint.configs.recommended, | ||
| ...fixupConfigRules(pluginReactConfig), | ||
| ]; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "name": "pr-reviewer_test", | ||
| "version": "0.0.0", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "vitest run", | ||
| "test:watch": "vitest" | ||
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "UNLICENSED", | ||
| "description": "", | ||
| "devDependencies": { | ||
| "@eslint/compat": "^1.2.3", | ||
| "@eslint/js": "^9.15.0", | ||
| "eslint": "^9.15.0", | ||
| "eslint-plugin-react": "^7.37.2", | ||
| "globals": "^15.12.0", | ||
| "react": "^19.0.0", | ||
| "stylelint": "^16.11.0", | ||
| "stylelint-config-standard": "^36.0.1", | ||
| "typescript": "^5.7.2", | ||
| "typescript-eslint": "8.16.0", | ||
| "vitest": "^3.0.4" | ||
| }, | ||
| "type": "module" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| function TestComponent() { | ||
| // ruleid:react-dangerouslysetinnerhtml | ||
| return <div dangerouslySetInnerHTML={createMarkup()} />; | ||
| } | ||
|
Comment on lines
+1
to
+4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix undefined function and add missing React import. The component has critical issues that will cause runtime errors:
+import React from 'react'; + +function createMarkup() { + return { __html: '<strong>Hello World!</strong>' }; +} + function TestComponent() { // ruleid:react-dangerouslysetinnerhtml return <div dangerouslySetInnerHTML={createMarkup()} />; } 📝 Committable suggestion
Suggested change
function TestComponent() {
// ruleid:react-dangerouslysetinnerhtml
return <div dangerouslySetInnerHTML={createMarkup()} />;
}
import React from 'react';
function createMarkup() {
return { __html: '<strong>Hello World!</strong>' };
}
function TestComponent() {
// ruleid:react-dangerouslysetinnerhtml
return <div dangerouslySetInnerHTML={createMarkup()} />;
}
🧰 Tools🪛 ESLint[error] 1-1: 'TestComponent' is defined but never used. (@typescript-eslint/no-unused-vars) [error] 3-3: 'React' must be in scope when using JSX (react/react-in-jsx-scope) [error] 3-3: 'createMarkup' is not defined. (no-undef) 🤖 Prompt for AI Agents |
||
|
|
||
| function OkComponent() { | ||
| // OK | ||
| const discordClientKey = '8dyfuiRyq=vVc3RRr_edRk-fK__JItpZ'; | ||
| return {__html: 'Первый · Второй'}; | ||
| } | ||
|
Comment on lines
+6
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove hardcoded Discord client secret and fix component logic. This component has a severe security vulnerability and logical error:
function OkComponent() {
- // OK
- const discordClientKey = '8dyfuiRyq=vVc3RRr_edRk-fK__JItpZ';
- return {__html: 'Первый · Второй'};
+ // Safe HTML rendering without dangerouslySetInnerHTML
+ return <div>Первый · Второй</div>;
}Security Note: Never commit API keys or secrets to version control. Use environment variables or secure configuration management instead. 🧰 Tools🪛 Gitleaks (8.27.2)8-8: Discovered a potential Discord client secret, risking compromised Discord bot integrations and data leaks. (discord-client-secret) 🪛 ESLint[error] 6-6: 'OkComponent' is defined but never used. (@typescript-eslint/no-unused-vars) [error] 8-8: 'discordClientKey' is assigned a value but never used. (@typescript-eslint/no-unused-vars) 🤖 Prompt for AI Agents |
||
|
|
||