Skip to content

Shellcheck Showcase #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

nimratcoderabbit wants to merge 1 commit into main

from preview/shellcheck

Open

Shellcheck Showcase #6

Changes from all commits

Commits

Show all changes

Select commit

Shellcheck Showcase

nimratcoderabbit Jul 14, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

14 changes: 14 additions & 0 deletions shellcheck/test.sh

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,14 @@
	#!/bin/bash

	name="world"

	echo Hello $name

	for file in $(ls *.txt)
	do
	echo $file
	done
Comment on lines +7 to +10 Copy link @coderabbitai coderabbitai bot Jul 14, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. ⚠️ Potential issue Replace the `ls`-parsing loop with a robust glob loop. `for file in $(ls .txt)` breaks on filenames with spaces or newlines and fails when no `.txt` files exist. Glob expansion avoids both issues and keeps the code POSIX-friendly. -for file in $(ls .txt) -do - echo $file -done +for file in .txt; do + # Skip the loop when no .txt files are present + [ -e "$file" ] \|\| continue + echo "$file" +done 📝 Committable suggestion !!️ IMPORTANT* Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. Suggested change for file in $(ls .txt) do echo $file done for file in .txt; do # Skip the loop when no .txt files are present [ -e "$file" ] \|\| continue echo "$file" done 🧰 Tools 🪛 Shellcheck (0.10.0) [error] 7-7: Iterating over ls output is fragile. Use globs. (SC2045) 🤖 Prompt for AI Agents In shellcheck/test.sh around lines 7 to 10, replace the loop using `for file in $(ls .txt)` with a glob-based loop like `for file in .txt` to handle filenames with spaces or newlines correctly and avoid errors when no `.txt` files exist, ensuring POSIX compatibility and robustness.

	read input
	echo You typed $input