-
Notifications
You must be signed in to change notification settings - Fork 58
Add Rustdesk module #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rustdesk module #266
Conversation
@matifali can you release the pending asset (150$)?
@matifali can you release the pending asset (150$)?
This is released automatically once the PR is merged and closed
@matifali can you release the pending asset (150$)?
This is released automatically once the PR is merged and closed
No comment! But why I'm being delayed as this PR resolve the issue?
@matifali can you release the pending asset (150$)?
This is released automatically once the PR is merged and closed
No comment! But why I'm being delayed as this PR resolve the issue?
There is no intentional delay, as Algora releases the bounty once the PR is approved, and merged.
This is outlined in the Coder Bounty Issue #213
@BenraouaneSoufiane Just checking if there is any update on this?
@BenraouaneSoufiane Just checking if there is any update on this?
Fixed, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new RustDesk module that enables remote desktop access within Coder workspaces. The module automates the installation of RustDesk, sets up a virtual display using Xvfb, and provides connection credentials for remote access.
Key changes:
- Adds a complete RustDesk module with cross-platform package manager support
- Implements automatic password generation and virtual display configuration
- Provides Terraform integration with configurable parameters
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
registry/BenraouaneSoufiane/modules/rustdesk/run.sh |
Main installation and setup script with package manager detection and RustDesk configuration |
registry/BenraouaneSoufiane/modules/rustdesk/main.tf |
Terraform module definition with variables and Coder resource configuration |
registry/BenraouaneSoufiane/modules/rustdesk/README.md |
Module documentation with usage instructions and configuration examples |
registry/BenraouaneSoufiane/README.md |
Author profile information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...dcoded version. Fix loging so that it will actually output to workspace logs.
...fy virtual display setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DevelopmentCats Everything looks good, but still couldn't figure out what are changes requested by you
@DevelopmentCats I got changes requested but i couldn't see them, can you outline them?
I was running this module to test it last night, and I was having issues but could not see them because the module wasn't properly logging in way that the workspace build would include it.
I made some changes so that it would do so and it seemed like the issue was with xvfb stalling and the workspace build would never complete for me, after following the guidance provided in the README. I will mess with it a bit more this morning to see what the problem that we are having now is.
I was running this module to test it last night, and I was having issues but could not see them because the module wasn't properly logging in way that the workspace build would include it.
I made some changes so that it would do so and it seemed like the issue was with xvfb stalling and the workspace build would never complete for me, after following the guidance provided in the README. I will mess with it a bit more this morning to see what the problem that we are having now is.
As initital review, it requires coder' server to be run as root then you should incorporate this in the template: user = "root" , also after editing the run.sh, please note that this command
sudo rustdesk --password "${RUSTDESK_PASSWORD}" >> "${LOG_PATH}" 2>&1 || true
could works only for exisiting rustdesk process/instance, so it should be other command before it, which were removed now
please note that this module specially requires a root scope because it shares everything, the command --password works only with root user
Fix failed build/script exit
@DevelopmentCats Hello again, I just fix the build/script exit:
https://youtu.be/Tbpl6HTJjtU
@DevelopmentCats Hello again, in fact all the workflow checks were passed, after your last two commits, looking to hear from you (if not busy of course)
@DevelopmentCats then what's next?
@BenraouaneSoufiane I think this module is pretty much good to go now. Let me pull it into my deployment and test it one more time to make sure all the features work as expected and then we should be good to merge this. Sorry for the delay on this, and thank you for being patient!
@BenraouaneSoufiane I think this module is pretty much good to go now. Let me pull it into my deployment and test it one more time to make sure all the features work as expected and then we should be good to merge this. Sorry for the delay on this, and thank you for being patient!
Good news, in fact I know you're busy!
@DevelopmentCats Hello again, thank you for you latest commits, I've checked the new version it works fine, https://youtu.be/YAMjDqFsV4I
Uh oh!
There was an error while loading. Please reload this page.
Closes #79
Description
This PR add new module, install minimal desktop environment (xfce), virtual display, ,rustdesk package from deb file, init new screen, export DISPLAY environment variable with last created virtual screen, start new xfce session & execute the rustdesk cli, generate new password, change the default password, then log the ID & password to be used within rustdesk client to connect to the host
Type of Change
Module Information
Overview/test video: live demo that launch rustdesk with GUI in a docker container https://youtu.be/_rR-l7nARN4
Screenshots:
image
image
image
image
Path:
registry/BenraouaneSoufiane/modules/rustdeskNew version:
v1.0.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues
/claim #79 (remain asset 150$)