-
Notifications
You must be signed in to change notification settings - Fork 6
fix: properly determine running workspaces count #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ethanndickson
ethanndickson
force-pushed
the
ethan/fix-running-workspaces-count
branch
from
September 9, 2025 04:19
06a34d9
to
97edcfc
Compare
@ethanndickson
ethanndickson
force-pushed
the
ethan/fix-running-workspaces-count
branch
from
September 9, 2025 06:32
97edcfc
to
7e99438
Compare
@ethanndickson
ethanndickson
changed the title
(削除) fix: use succeeded provisioner jobs when determining running workspace count (削除ここまで)
(追記) fix: properly determining running workspaces count (追記ここまで)
Sep 9, 2025
@ethanndickson
ethanndickson
requested a review
from dannykopping
as a code owner
September 9, 2025 06:41
@ethanndickson
ethanndickson
changed the title
(削除) fix: properly determining running workspaces count (削除ここまで)
(追記) fix: properly determine running workspaces count (追記ここまで)
Sep 9, 2025
dannykopping
dannykopping
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
Can you cut a patch release pls? https://github.com/coder/observability/blob/main/PUBLISH.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Part of the previous query didn't make sense and was completely wrong (though it is admittedly confusing). Here's part of the DB query for retrieving running workspaces:
This new promql query follows this logic, but also uses a max by to handle duplicate metrics from multiple coder replicas:
Tested on dogfood and on my scaletest cluster.