-
Notifications
You must be signed in to change notification settings - Fork 6
fix: use creatordate to pick latest tag instead of version sort #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ssncferreira
ssncferreira
requested a review
from dannykopping
as a code owner
September 8, 2025 12:06
dannykopping
dannykopping
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@ssncferreira
ssncferreira
deleted the
ssncferreira/fix-publish-latest-tag
branch
September 8, 2025 12:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
version.shscript to determine the latest version by creation date instead of semantic sorting.The publish.sh script relies on this version to publish to the Helm repo.
Previously, semantic sorting caused release candidates (e.g.
0.4.0-rc.6) to be considered newer than the final stable release (0.4.0).With this change, stable versions are correctly treated as the latest release.