Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add test for overwriting replica values #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jsjoeio wants to merge 6 commits into main
base: main
Choose a base branch
Loading
from jsjoeio/add-helm-test

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Nov 8, 2021 •
edited
Loading

This PR adds a new test which tests for overwriting the replicas value in the default yaml template.

Fixes #165

@jsjoeio jsjoeio self-assigned this Nov 8, 2021
@jsjoeio jsjoeio changed the title (削除) feat: add helm test for ingress example (削除ここまで) (追記) feat: add test for postgres values (追記ここまで) Nov 8, 2021
@jsjoeio jsjoeio changed the title (削除) feat: add test for postgres values (削除ここまで) (追記) feat: add test for overwriting replica values (追記ここまで) Nov 8, 2021
Comment on lines +50 to +53
objs, err := RenderChart(chart, ValuesToOverwrite, nil, nil)
// TODO@jsjoeio - getting an error here
// error deserializing "coder/templates/coderd.yaml": yaml: line 9: mapping values are not allowed in this context
require.NoError(t, err, "failed to render chart")
Copy link
Contributor Author

@jsjoeio jsjoeio Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawnsy I feel like I'm so close. I'm doing something wrong though and getting this error. Any ideas?

image

Copy link
Contributor Author

jsjoeio commented Nov 8, 2021

This is blocked until Jonathan and I fix bug in RenderChart

Copy link
Contributor

jawnsy commented Dec 6, 2021

@jsjoeio I think this should be unblocked now, but may be kind of tricky as a lot of things have changed in the API. Might be best to reset your branch to the latest main and try again?

Copy link
Contributor Author

jsjoeio commented Dec 7, 2021

I think this should be unblocked now, but may be kind of tricky as a lot of things have changed in the API. Might be best to reset your branch to the latest main and try again?

ahh good to know! I'll restart this work hopefully next week 🤞 Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test for overwriting replicas value
2 participants

AltStyle によって変換されたページ (->オリジナル) /