-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Patch welcome page #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving this here as a note not to merge yet; we're gonna provide the URLs (via product.ts) instead of replacing the hrefs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer commenting this out <!-- --> so the patch can be as minimal and additive as possible, should help with potential merge conflicts when we update VS Code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it might be a good idea for us to actually implement the "open recent" commands at some point.
Not sure we should do this. I feel like it could be rough to maintain.
Patch welcome page for non-working links