Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Clearify wording #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShalokShalom wants to merge 2 commits into coder:master from ShalokShalom:patch-1
Closed

Clearify wording #781

ShalokShalom wants to merge 2 commits into coder:master from ShalokShalom:patch-1

Conversation

Copy link

@ShalokShalom ShalokShalom commented Jun 16, 2019

Which screenshot? 😃

Copy link
Member

The screenshot is supposed to be the <img> at the end of the line, but it looks like there's one too many ../s in the URL.

Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an image that's supposed to load after this paragraph (the <img> at the end of the line), but the URL is incorrect. Instead of removing the "following screenshot" stuff, the URL should be fixed.

Copy link
Author

ShalokShalom commented Jun 17, 2019
edited
Loading

Who knows the new URL?

Copy link
Member

Just remove one of the ../s from the URL.

### Things To Know
- When you visit the IP for your code-server instance, you will be greeted with a page similar to the following screenshot. Code-server is using a self-signed SSL certificate for easy setup. In Chrome/Chromium, click **"Advanced"** then click **"proceed anyway"**. In Firefox, click **Advanced**, then **Add Exception**, then finally **Confirm Security Exception**.<img src ="../../assets/chrome_warning.png">
- When you visit the IP for your code-server instance, you will be greeted with a screen similar to that one in the screenshot. Code-server is using a self-signed SSL certificate for easy setup. In Chrome/Chromium, click **"Advanced"** then click **"proceed anyway"**. In Firefox, click **Advanced**, then **Add Exception**, then finally **Confirm Security Exception**.<img src ="../assets/chrome_warning.png">
Copy link
Member

@deansheather deansheather Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording is less clear and should be reverted to what it was originally.

NGTmeaty reacted with thumbs up emoji
Copy link
Member

@deansheather deansheather Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been resolved.

Copy link
Author

@ShalokShalom ShalokShalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure

Copy link
Member

@ShalokShalom Could you please make my requested changes so I can merge this?

Copy link
Author

Do it for yourself -.-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather requested changes

@code-asher code-asher Awaiting requested review from code-asher

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /