-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Update Code to 1.104.0 #7488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Code to 1.104.0 #7488
Conversation
The local build succeeds, but npm run test:integration
fails with
> code-server@0.0.0 test:integration
> ./ci/dev/test-integration.sh
Set CODE_SERVER_PATH to test another build of code-server
Running tests with code-server binary: 'release-standalone/bin/code-server'
PASS test/integration/help.test.ts
FAIL test/integration/installExtension.test.ts
●くろまる --install-extension › should use EXTENSIONS_GALLERY when set
expect(received).rejects.toThrow(expected)
Expected substring: "No extension gallery service configured"
Received message: "Command failed: release-standalone/bin/code-server --extensions-dir /tmp/code-server/tests/installExtension/installExtension-TcooxM --install-extension author.extension
[2025年09月11日T16:04:34.845Z] [
ReferenceError: __dirname is not defined
at Module.EV (file:///home/benz0li/projects/coder/code-server/release-standalone/lib/vscode/out/server-main.js:231:141)
at /home/benz0li/projects/coder/code-server/release-standalone/out/node/main.js:84:40
at Generator.next (<anonymous>)
at fulfilled (/home/benz0li/projects/coder/code-server/release-standalone/out/node/main.js:38:58) {
[stack]: [Getter/Setter],
[message]: '__dirname is not defined'
},
[length]: 1
]error Got error from Code
"
at Module.EV (file:/home/benz0li/projects/coder/code-server/release-standalone/lib/vscode/out/server-main.js:231:141)
at /home/benz0li/projects/coder/code-server/release-standalone/out/node/main.js:84:40
at fulfilled (release-standalone/out/node/main.js:38:58) {
[stack]: [Getter/Setter],
[message]: '__dirname is not defined'
},
[length]: 1
]error Got error from Code
18 | EXTENSIONS_GALLERY: "{}",
19 | }),
> 20 | ).rejects.toThrow("No extension gallery service configured")
| ^
21 | })
22 | })
23 |
at Object.toThrow (test/node_modules/expect/build/index.js:285:22)
at test/integration/installExtension.test.ts:20:15
at test/integration/installExtension.test.ts:8:71
at Object.<anonymous>.__awaiter (test/integration/installExtension.test.ts:4:12)
at Object.<anonymous> (test/integration/installExtension.test.ts:14:59)
Test Suites: 1 failed, 1 passed, 2 total
Tests: 1 failed, 1 passed, 2 total
Snapshots: 0 total
Time: 2.876 s, estimated 4 s
Ran all test suites.
code-server-4.104.0-rc.1-linux-amd64.tar.gz
with Code 1.104.0 is deployed at https://coder.jupyter.b-data.ch.
Opening code-server
results in a HTTP 500 __dirname is not defined
.
@code-asher IMHO this fails due to some change in lib/vscode/src/server-main.ts
regarding startup.
The SHA-256 in lib/vscode/src/vs/workbench/contrib/webview/browser/pre/index.html
changed, too.
i️ I was unable to update, because I could not startup code-server
.
I pushed a fix that hopefully works for __dirname
🤞
A new version of code-server-4.104.0-rc.1-linux-amd64.tar.gz
with Code 1.104.0 is deployed at https://coder.jupyter.b-data.ch.
Functionality [modified by patches] tested and found to work:
- base-path
- cli-window-open
- local-storage
- marketplace
- proxy-url
- service-worker
- web view
Workspaces and Jupyter Notebooks also work fine:
ms-toolsai.jupyter@202580
ms-python.python@2025140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #7480