Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Open VSX marketplace URL gallery path issue #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 3 commits into coder:main from jinvien:main
Sep 11, 2025
Merged

Conversation

Copy link
Contributor

@jinvien jinvien commented Sep 6, 2025

Description
This PR fixes a URL path issue in the Open VSX marketplace integration that was causing incorrect redirects.

Problem
vscode extension gallery was generating incorrect URLs with an extra /vscode segment:

❌ Incorrect: https://open-vsx.org/vscode/gallery/vscode/eamodio/gitlens/latest
✅ Correct: https://open-vsx.org/vscode/gallery/eamodio/gitlens/latest
The incorrect URL format was causing redirects to http://open-vsx.org/error instead of properly resolving extension resources.

Changes
Fixed the extension latest version URI template in extensionGalleryManifestService.ts by removing the redundant /vscode segment

@jinvien jinvien requested a review from a team as a code owner September 6, 2025 09:33
Copy link
Member

Ohhhhhhh interesting is this why extension installations sometimes fail??

But, I am not sure if we can merge this because there are other marketplaces (such as code-marketplace) that do include the /vscode so this would break those.

Also, what about other VS Code-based alternatives like VSCodium? I imagine they must have the same bug. Maybe this needs to be fixed on Open VSX's side?

If not, then maybe we will need to pull this off extensionsGallery instead so it can be customized.

Copy link
Member

code-asher commented Sep 8, 2025
edited
Loading

Actually, eclipse/openvsx#1283 suggests we can set extensionUrlTemplate on extensionsGallery to fix this. Looks like VSCodium works because it sets this, so we can do the same (in this same patch).

jinvien reacted with thumbs up emoji

Copy link
Contributor Author

jinvien commented Sep 9, 2025

Yes, this is clearly a more elegant solution. I've updated the commit accordingly—please take a look when you have a moment.

Also, I’m not entirely sure whether my commit should include changes to changelog.md. I noticed in your contribution guidelines that updates related to the marketplace should be reflected in the changelog. Could you please advise on whether that’s needed here?

Thanks!

Copy link
Member

Awesome thank you!

I’m not entirely sure whether my commit should include changes to changelog.md

Yup, I think it would be good to call out this fix in the change log. No worries about it generally though, before releasing I always go through the commits and add anything that is missing to the change log.

@code-asher code-asher merged commit 1a7b770 into coder:main Sep 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /