Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update Code to 1.102.0 #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 2 commits into coder:main from benz0li:code-1.102.0
Jul 15, 2025
Merged

Update Code to 1.102.0 #7418

code-asher merged 2 commits into coder:main from benz0li:code-1.102.0
Jul 15, 2025

Conversation

Copy link
Contributor

@benz0li benz0li commented Jul 11, 2025

Fixes #7414

@benz0li benz0li requested a review from a team as a code owner July 11, 2025 05:01
Copy link
Contributor Author

benz0li commented Jul 11, 2025

@code-asher Please review:

Applying patch patches/display-language.diff
patching file lib/vscode/src/vs/server/node/serverServices.ts
Hunk #2 succeeded at 267 with fuzz 2 (offset 12 lines).
patching file lib/vscode/src/vs/platform/environment/common/environmentService.ts
Hunk #1 succeeded at 98 (offset -3 lines).
patching file lib/vscode/src/vs/server/node/remoteLanguagePacks.ts
patching file lib/vscode/src/vs/server/node/webClientServer.ts
patching file lib/vscode/src/vs/server/node/serverEnvironmentService.ts
Hunk #1 succeeded at 21 (offset 2 lines).
Hunk #2 succeeded at 110 (offset 2 lines).
patching file lib/vscode/src/vs/platform/languagePacks/browser/languagePacks.ts
can't find file to patch at input line 251
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: code-server/lib/vscode/src/vs/workbench/services/localization/electron-sandbox/localeService.ts
|===================================================================
|--- code-server.orig/lib/vscode/src/vs/workbench/services/localization/electron-sandbox/localeService.ts
|+++ code-server/lib/vscode/src/vs/workbench/services/localization/electron-sandbox/localeService.ts
--------------------------
No file to patch. Skipping patch.
2 out of 2 hunks ignored
patching file lib/vscode/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
patching file lib/vscode/build/gulpfile.reh.js
Hunk #1 FAILED at 58.
1 out of 1 hunk FAILED -- saving rejects to file lib/vscode/build/gulpfile.reh.js.rej
patching file lib/vscode/src/vs/workbench/workbench.web.main.internal.ts
Applied patch patches/display-language.diff (forced; needs refresh)

Copy link
Contributor Author

benz0li commented Jul 11, 2025

Copy link
Contributor Author

benz0li commented Jul 11, 2025

Local build:

npm run build:vscode
> code-server@0.0.0 build:vscode
> ./ci/build/build-vscode.sh
Updated 0 paths from the index
> code-oss-dev@1.102.0 gulp
> node --max-old-space-size=8192 --optimize-for-size ./node_modules/gulp/bin/gulp.js vscode-reh-web-linux-x64-min
[06:59:09] Using gulpfile ~/projects/coder/code-server/lib/vscode/gulpfile.js
[06:59:09] Starting 'vscode-reh-web-linux-x64-min'...
[06:59:09] Starting clean-out-build ...
[06:59:09] Finished clean-out-build after 3 ms
[06:59:09] Starting build-date-file ...
[06:59:09] Finished build-date-file after 1 ms
[06:59:09] Starting compile-api-proposal-names ...
[06:59:09] Starting compilation api-proposal-names...
(node:20774) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
[06:59:09] Finished compilation api-proposal-names with 0 errors after 94 ms
[06:59:09] Finished compile-api-proposal-names after 106 ms
[06:59:09] Starting compile-src ...
[06:59:41] [mangler] Done collecting. Classes: 9026. Exported symbols: 11040
[06:59:45] [mangler] Done creating class replacements
[06:59:45] [mangler] Starting prepare rename edits
[06:59:47] Starting compilation...
[07:25:41] [mangler] Done preparing edits: 4539 files
[07:25:57] [mangler] Done: 5568.63kb saved, memory-usage: {"total_heap_size":2460643328,"total_heap_size_executable":9150464,"total_physical_size":2457845760,"total_available_size":6169903880,"used_heap_size":2385333176,"heap_size_limit":8593080320,"malloced_memory":3189008,"peak_malloced_memory":20058864,"does_zap_garbage":0,"number_of_native_contexts":1,"number_of_detached_contexts":0,"total_global_handles_size":5390336,"used_global_handles_size":2119616,"external_memory":112260207}
[07:34:53] Error: /home/benz0li/projects/coder/code-server/lib/vscode/src/vs/workbench/workbench.web.main.internal.ts(56,8): Cannot find module './services/localization/electron-sandbox/localeService.js' or its corresponding type declarations.
[07:34:53] Finished compilation with 1 errors after 2105643 ms
[07:34:53] Error: /home/benz0li/projects/coder/code-server/lib/vscode/src/vs/workbench/workbench.web.main.internal.ts(56,8): Cannot find module './services/localization/electron-sandbox/localeService.js' or its corresponding type declarations.
[07:34:53] Finished compilation with 1 errors after 2105643 ms
[07:34:53] 'vscode-reh-web-linux-x64-min' errored after 36 min
[07:34:53] Error: Found 1 errors
 at Stream.<anonymous> (/home/benz0li/projects/coder/code-server/lib/vscode/build/lib/reporter.js:94:29)
 at _end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:65:9)
 at stream.end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:74:5)
 at Stream.onend (node:internal/streams/legacy:48:10)
 at Stream.emit (node:events:530:35)
 at Stream.emit (node:domain:552:15)
 at drain (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:34:23)
 at stream.queue.stream.push (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:45:5)
 at Stream.end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:15:35)
 at _end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:65:9)

Copy link
Contributor Author

benz0li commented Jul 11, 2025

Modified <path>/<to>/electron-sandbox/localeService.js to <path>/<to>/electron-browser/localeService.js in patches/display-language.diff.

Copy link
Contributor Author

benz0li commented Jul 11, 2025

Copy link
Contributor Author

benz0li commented Jul 11, 2025

code-server-4.102.0-rc.1-linux-amd64.tar.gz with Code 1.102.0 is deployed at https://coder.jupyter.b-data.ch.

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • web view

Workspaces and Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@202560
  • ms-python.python@202540

Copy link
Contributor Author

benz0li commented Jul 14, 2025

@code-asher Please rerun Build / Build code-server (pull_request) and check what is going wrong.

Copy link
Contributor Author

benz0li commented Jul 14, 2025

@code-asher My local build was successful and is deployed at https://coder.jupyter.b-data.ch.

Copy link
Member

code-asher commented Jul 14, 2025
edited
Loading

Weird, not sure why it keeps canceling. I would guess it is hitting the 60 minute timeout except it seems to be canceling far earlier than that...investigating...maybe it is OOM

benz0li reacted with thumbs up emoji

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was running out of memory.

Thank you for doing the update!!

benz0li reacted with heart emoji
@code-asher code-asher merged commit cdac5bf into coder:main Jul 15, 2025
12 checks passed
jiridanek added a commit to opendatahub-io/notebooks that referenced this pull request Sep 10, 2025
jiridanek added a commit to opendatahub-io/notebooks that referenced this pull request Sep 10, 2025
jiridanek added a commit to opendatahub-io/notebooks that referenced this pull request Sep 10, 2025
jiridanek added a commit to jiridanek/notebooks that referenced this pull request Sep 10, 2025
jiridanek added a commit to opendatahub-io/notebooks that referenced this pull request Sep 10, 2025
jiridanek added a commit to jiridanek/notebooks that referenced this pull request Sep 18, 2025
...dy in code-sever
* coder/code-server#7418
Revert "increase available memory for the nodejs javascript vm (opendatahub-io#2356)"
This reverts commit e3f47c1.
jiridanek added a commit to opendatahub-io/notebooks that referenced this pull request Sep 19, 2025
...dy in code-sever
* coder/code-server#7418
Revert "increase available memory for the nodejs javascript vm (#2356)"
This reverts commit e3f47c1.
jiridanek added a commit to opendatahub-io/notebooks that referenced this pull request Sep 19, 2025
...dy in code-sever
* coder/code-server#7418
Revert "increase available memory for the nodejs javascript vm (#2356)"
This reverts commit e3f47c1.
daniellutz added a commit to opendatahub-io/notebooks that referenced this pull request Sep 19, 2025
* RHOAIENG-34309: fix(jupyterlab-extension): remove gio command call and use custom code to clean trashed files (#2510)
* #1271: fix(scripts): posix noncompliance in `nginx/root/usr/share/container-scripts/nginx/common.sh` and duplicates of thereof (#1628)
* fix(nginx/common.sh) fix shell script that was not POSIX-complaint
Let's rather add the `#!/usr/bin/env bash` and just use bash
---------
Co-authored-by: Jiri Daněk <jdanek@redhat.com>
* update all runtimes imagestreams name to reflect to the new naming format
* RHAIENG-1186: chore(dockerfile): bump code-server version to v4.104.0 in UBI9 Python 3.12 image
* RHAIENG-1186: chore(dockerfile): remove custom patch, change is already in code-sever
* coder/code-server#7418
Revert "increase available memory for the nodejs javascript vm (#2356)"
This reverts commit e3f47c1.
* RHAIENG-1186: chore(code-server): update nodejs to a compatible version
Choosing 2.24 because we're building for RHOAI 2.25 EUS.
```
> code-oss-dev@1.104.0 preinstall
> node build/npm/preinstall.js
*** Please use Node.js v22.15.1 or later for development.
/root/code-server/lib/vscode/build/npm/preinstall.js:14
```
* RHAIENG-1186: chore(code-server): update to gcc-toolset-14 with CXXFLAGS="-std=c++20"
```
npm error /root/.cache/node-gyp/24.8.0/include/node/v8config.h:13:2: error: #error "C++20 or later required."
npm error 13 | #error "C++20 or later required."
```
* RHAIENG-1186: chore(code-server): the build is unhappy about nodejs 24, so use 22.19.0
```
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: 'code-server@0.0.0',
npm warn EBADENGINE required: { node: '22' },
npm warn EBADENGINE current: { node: 'v24.8.0', npm: '11.6.0' }
npm warn EBADENGINE }
```
* RHAIENG-1186: chore(code-server): it looks like there may be a justification for installing node 22.18
When I had 22.19.0, the build downloaded 22.18.0 at one point.
```
 [18:37:46] Starting node-linux-x64 ...
 [18:37:46] Downloading node.js 22.18.0 linux x64 from https://nodejs.org...
```
* RHAIENG-1186: chore(code-server): disable the getting started override about deploying code-server for the team
https://github.com/coder/code-server/blob/v4.104.0/patches/getting-started.diff
* RHAIENG-1023: fix(rstudio): update the esbuild inside of rstudio's installation as it was done in the poc (#2513)
* Fix typos
* Issue #1789: chore(repo): set up lfs for vscode extensions vendored into the repo (#2516)
For now, only move existing extensions already on main into lfs. Will not rewrite history to remove the previously added versions.
This means that repository size is not decreased by this commit. But it should not grow so much any more every time code-server is updated.
```
❯ brew install git-lfs
❯ git lfs track "*.vsix"
Tracking "*.vsix"
❯ cat .gitattributes
ci/secrets/** filter=git-crypt diff=git-crypt
*.vsix filter=lfs diff=lfs merge=lfs -text
❯ git add .gitattributes
```
Issue #1789: chore(repo): update docs with git-lfs instructions for codeserver in Extensions.md
* Issue #1789: chore(repo): convert the ``*.vsix` files on main into git-lfs (#2516)
codeserver/ubi9-python-3.12/utils/ms-python.debugpy-2025年4月1日@linux-x64.vsix,codeserver/ubi9-python-3.12/utils/ms-python.python-202520.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.jupyter-202520.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.jupyter-keymap-1.1.2.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.jupyter-renderers-1.1.0.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.vscode-jupyter-cell-tags-0.1.9.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.vscode-jupyter-slideshow-0.1.6.vsix: convert to Git LFS
```
❯ git lfs migrate import --no-rewrite codeserver/ubi9-python-3.12/utils/*.vsix
override changes in your working copy? All uncommitted changes will be lost! [y/N] y
changes in your working copy will be overridden ...
Checkout: ..., done.
```
* Issue #1789: chore(repo): add a conditional git-lfs checkout in github actions when needed (#2516)
```
[4/6] STEP 13/33: RUN mkdir -p /opt/app-root/extensions-temp && code-server --install-extension /opt/app-root/bin/utils/ms-python.python-202520.vsix --extensions-dir /opt/app-root/extensions-temp && code-server --install-extension /opt/app-root/bin/utils/ms-toolsai.jupyter-202520.vsix --extensions-dir /opt/app-root/extensions-temp
[2025年09月19日T08:59:44.572Z] info Wrote default config file to /opt/app-root/src/.config/code-server/config.yaml
Installing extensions...
Error: End of central directory record signature not found. Either not a zip file, or file is truncated.
 at k8 (file:///usr/lib/code-server/lib/vscode/out/server-main.js:48:2239)
 at file:///usr/lib/code-server/lib/vscode/out/server-main.js:48:3567
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/index.js:40:7
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/index.js:190:5
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/index.js:712:5
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/fd-slicer.js:33:7
 at FSReqCallback.wrapper [as oncomplete] (node:fs:671:5) {
 code: 'Extract',
 name: 'Extract'
}
Failed Installing Extensions: file:///opt/app-root/bin/utils/ms-python.python-202520.vsix
```
I'll locate the workflow template and the code paths that determine when a codeserver image is being built, then update the checkout step to use LFS conditionally.
[2 tools called]
I'll open the workflow template to see the checkout step and the job matrix to identify how to detect codeserver builds, then edit it to set checkout lfs conditionally.
[1 tool called]
I’m going to update the workflow template to set the checkout action’s LFS option conditionally: enabled when `inputs.target` contains `codeserver`, disabled otherwise, for both the normal and pull_request_target checkout steps.
[2 tools called]
- I found the workflow template and updated the checkout steps to toggle LFS based on whether we’re building a codeserver image.
Changes made in `.github/workflows/build-notebooks-TEMPLATE.yaml`:
- For both checkout steps, added `with.lfs: ${{ contains(inputs.target, 'codeserver') }}`.
- This sets LFS to true when `inputs.target` contains `codeserver`, and false otherwise, including the `pull_request_target` case.
Example of the updated blocks:
```12:16:.github/workflows/build-notebooks-TEMPLATE.yaml
 - uses: actions/checkout@v5
 if: ${{ fromJson(inputs.github).event_name != 'pull_request_target' }}
 with:
 lfs: ${{ contains(inputs.target, 'codeserver') }}
```
```66:71:.github/workflows/build-notebooks-TEMPLATE.yaml
 - uses: actions/checkout@v5
 if: ${{ fromJson(inputs.github).event_name == 'pull_request_target' }}
 with:
 ref: "refs/pull/${{ fromJson(inputs.github).event.number }}/merge"
 lfs: ${{ contains(inputs.target, 'codeserver') }}
```
Summary:
- Conditional LFS checkout implemented in the workflow template for codeserver builds; no lints reported.
* RHAIENG-286: 2025b images package upgrade (#2414)
* Upgrade CodeServer packages for 2025b
* Upgrade Jupyter DataScience packages for 2025b
* Upgrade Jupyter Minimal packages for 2025b
* Upgrade Jupyter PyTorch LLMCompressor packages for 2025b
* Upgrade Jupyter PyTorch packages for 2025b
* Upgrade Jupyter ROCm PyTorch packages for 2025b
* Upgrade Jupyter ROCm TensorFlow packages for 2025b
* Upgrade Jupyter TensorFlow packages for 2025b
* Upgrade Jupyter TrustyAI packages for 2025b
* Upgrade RStudio packages for 2025b
* Upgrade Runtime images for 2025b
* Update Makefile's RELEASE flag to `2025b` version
* Change build-args to use CUDA 12.8 instead of CUDA 12.6
* Fix tests, manifests and try to ensure consistency between packages and images
* Fix minor package version check and ruff linter issues
* Add missing comma to tuples on tests
* Ignore RUFF's COM819 about commas and lists
* Use RUFF format to fix minor indentation issues
* Update wrong CodeFlare SDK version on packages to standardize them
* Update build-args for ROCm-based images to use ROCm v6.4 instead of ROCm v6.2
* RHAIENG-1193: codeserver(repo): update vscode extensions for 2025b release from Open VSX Registry (#2518)
---------
Co-authored-by: William Antônio Siqueira <william.fatecsjc@gmail.com>
Co-authored-by: satnam72 <125819218+satnam72@users.noreply.github.com>
Co-authored-by: Jiri Daněk <jdanek@redhat.com>
Co-authored-by: dibryant <dibryant@redhat.com>
Co-authored-by: Daniel Lutz <dlutz@redhat.com>
jiridanek added a commit to opendatahub-io/notebooks that referenced this pull request Sep 28, 2025
* RHOAIENG-34309: fix(jupyterlab-extension): remove gio command call and use custom code to clean trashed files (#2510)
* #1271: fix(scripts): posix noncompliance in `nginx/root/usr/share/container-scripts/nginx/common.sh` and duplicates of thereof (#1628)
* fix(nginx/common.sh) fix shell script that was not POSIX-complaint
Let's rather add the `#!/usr/bin/env bash` and just use bash
---------
Co-authored-by: Jiri Daněk <jdanek@redhat.com>
* update all runtimes imagestreams name to reflect to the new naming format
* RHAIENG-1186: chore(dockerfile): bump code-server version to v4.104.0 in UBI9 Python 3.12 image
* RHAIENG-1186: chore(dockerfile): remove custom patch, change is already in code-sever
* coder/code-server#7418
Revert "increase available memory for the nodejs javascript vm (#2356)"
This reverts commit e3f47c1.
* RHAIENG-1186: chore(code-server): update nodejs to a compatible version
Choosing 2.24 because we're building for RHOAI 2.25 EUS.
```
> code-oss-dev@1.104.0 preinstall
> node build/npm/preinstall.js
*** Please use Node.js v22.15.1 or later for development.
/root/code-server/lib/vscode/build/npm/preinstall.js:14
```
* RHAIENG-1186: chore(code-server): update to gcc-toolset-14 with CXXFLAGS="-std=c++20"
```
npm error /root/.cache/node-gyp/24.8.0/include/node/v8config.h:13:2: error: #error "C++20 or later required."
npm error 13 | #error "C++20 or later required."
```
* RHAIENG-1186: chore(code-server): the build is unhappy about nodejs 24, so use 22.19.0
```
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: 'code-server@0.0.0',
npm warn EBADENGINE required: { node: '22' },
npm warn EBADENGINE current: { node: 'v24.8.0', npm: '11.6.0' }
npm warn EBADENGINE }
```
* RHAIENG-1186: chore(code-server): it looks like there may be a justification for installing node 22.18
When I had 22.19.0, the build downloaded 22.18.0 at one point.
```
 [18:37:46] Starting node-linux-x64 ...
 [18:37:46] Downloading node.js 22.18.0 linux x64 from https://nodejs.org...
```
* RHAIENG-1186: chore(code-server): disable the getting started override about deploying code-server for the team
https://github.com/coder/code-server/blob/v4.104.0/patches/getting-started.diff
* RHAIENG-1023: fix(rstudio): update the esbuild inside of rstudio's installation as it was done in the poc (#2513)
* Fix typos
* Issue #1789: chore(repo): set up lfs for vscode extensions vendored into the repo (#2516)
For now, only move existing extensions already on main into lfs. Will not rewrite history to remove the previously added versions.
This means that repository size is not decreased by this commit. But it should not grow so much any more every time code-server is updated.
```
❯ brew install git-lfs
❯ git lfs track "*.vsix"
Tracking "*.vsix"
❯ cat .gitattributes
ci/secrets/** filter=git-crypt diff=git-crypt
*.vsix filter=lfs diff=lfs merge=lfs -text
❯ git add .gitattributes
```
Issue #1789: chore(repo): update docs with git-lfs instructions for codeserver in Extensions.md
* Issue #1789: chore(repo): convert the ``*.vsix` files on main into git-lfs (#2516)
codeserver/ubi9-python-3.12/utils/ms-python.debugpy-2025年4月1日@linux-x64.vsix,codeserver/ubi9-python-3.12/utils/ms-python.python-202520.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.jupyter-202520.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.jupyter-keymap-1.1.2.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.jupyter-renderers-1.1.0.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.vscode-jupyter-cell-tags-0.1.9.vsix,codeserver/ubi9-python-3.12/utils/ms-toolsai.vscode-jupyter-slideshow-0.1.6.vsix: convert to Git LFS
```
❯ git lfs migrate import --no-rewrite codeserver/ubi9-python-3.12/utils/*.vsix
override changes in your working copy? All uncommitted changes will be lost! [y/N] y
changes in your working copy will be overridden ...
Checkout: ..., done.
```
* Issue #1789: chore(repo): add a conditional git-lfs checkout in github actions when needed (#2516)
```
[4/6] STEP 13/33: RUN mkdir -p /opt/app-root/extensions-temp && code-server --install-extension /opt/app-root/bin/utils/ms-python.python-202520.vsix --extensions-dir /opt/app-root/extensions-temp && code-server --install-extension /opt/app-root/bin/utils/ms-toolsai.jupyter-202520.vsix --extensions-dir /opt/app-root/extensions-temp
[2025年09月19日T08:59:44.572Z] info Wrote default config file to /opt/app-root/src/.config/code-server/config.yaml
Installing extensions...
Error: End of central directory record signature not found. Either not a zip file, or file is truncated.
 at k8 (file:///usr/lib/code-server/lib/vscode/out/server-main.js:48:2239)
 at file:///usr/lib/code-server/lib/vscode/out/server-main.js:48:3567
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/index.js:40:7
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/index.js:190:5
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/index.js:712:5
 at /usr/lib/code-server/lib/vscode/node_modules/yauzl/fd-slicer.js:33:7
 at FSReqCallback.wrapper [as oncomplete] (node:fs:671:5) {
 code: 'Extract',
 name: 'Extract'
}
Failed Installing Extensions: file:///opt/app-root/bin/utils/ms-python.python-202520.vsix
```
I'll locate the workflow template and the code paths that determine when a codeserver image is being built, then update the checkout step to use LFS conditionally.
[2 tools called]
I'll open the workflow template to see the checkout step and the job matrix to identify how to detect codeserver builds, then edit it to set checkout lfs conditionally.
[1 tool called]
I’m going to update the workflow template to set the checkout action’s LFS option conditionally: enabled when `inputs.target` contains `codeserver`, disabled otherwise, for both the normal and pull_request_target checkout steps.
[2 tools called]
- I found the workflow template and updated the checkout steps to toggle LFS based on whether we’re building a codeserver image.
Changes made in `.github/workflows/build-notebooks-TEMPLATE.yaml`:
- For both checkout steps, added `with.lfs: ${{ contains(inputs.target, 'codeserver') }}`.
- This sets LFS to true when `inputs.target` contains `codeserver`, and false otherwise, including the `pull_request_target` case.
Example of the updated blocks:
```12:16:.github/workflows/build-notebooks-TEMPLATE.yaml
 - uses: actions/checkout@v5
 if: ${{ fromJson(inputs.github).event_name != 'pull_request_target' }}
 with:
 lfs: ${{ contains(inputs.target, 'codeserver') }}
```
```66:71:.github/workflows/build-notebooks-TEMPLATE.yaml
 - uses: actions/checkout@v5
 if: ${{ fromJson(inputs.github).event_name == 'pull_request_target' }}
 with:
 ref: "refs/pull/${{ fromJson(inputs.github).event.number }}/merge"
 lfs: ${{ contains(inputs.target, 'codeserver') }}
```
Summary:
- Conditional LFS checkout implemented in the workflow template for codeserver builds; no lints reported.
* RHAIENG-286: 2025b images package upgrade (#2414)
* Upgrade CodeServer packages for 2025b
* Upgrade Jupyter DataScience packages for 2025b
* Upgrade Jupyter Minimal packages for 2025b
* Upgrade Jupyter PyTorch LLMCompressor packages for 2025b
* Upgrade Jupyter PyTorch packages for 2025b
* Upgrade Jupyter ROCm PyTorch packages for 2025b
* Upgrade Jupyter ROCm TensorFlow packages for 2025b
* Upgrade Jupyter TensorFlow packages for 2025b
* Upgrade Jupyter TrustyAI packages for 2025b
* Upgrade RStudio packages for 2025b
* Upgrade Runtime images for 2025b
* Update Makefile's RELEASE flag to `2025b` version
* Change build-args to use CUDA 12.8 instead of CUDA 12.6
* Fix tests, manifests and try to ensure consistency between packages and images
* Fix minor package version check and ruff linter issues
* Add missing comma to tuples on tests
* Ignore RUFF's COM819 about commas and lists
* Use RUFF format to fix minor indentation issues
* Update wrong CodeFlare SDK version on packages to standardize them
* Update build-args for ROCm-based images to use ROCm v6.4 instead of ROCm v6.2
* RHAIENG-1193: codeserver(repo): update vscode extensions for 2025b release from Open VSX Registry (#2518)
---------
Co-authored-by: William Antônio Siqueira <william.fatecsjc@gmail.com>
Co-authored-by: satnam72 <125819218+satnam72@users.noreply.github.com>
Co-authored-by: Jiri Daněk <jdanek@redhat.com>
Co-authored-by: dibryant <dibryant@redhat.com>
Co-authored-by: Daniel Lutz <dlutz@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Code to 1.102

AltStyle によって変換されたページ (->オリジナル) /