-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix: invalid ESM module path on Windows #7162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #7162 +/- ## ======================================= Coverage ? 72.39% ======================================= Files ? 31 Lines ? 1913 Branches ? 414 ======================================= Hits ? 1385 Misses ? 446 Partials ? 82
Continue to review full report in Codecov by Sentry.
|
Interesting! We probably want to do the same in src/node/routes/vscode.ts I imagine? (line 61)
fix: invalid ESM module path on Windows.
Right. This exception may thrown by vscode.js on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Thank you for doing this! The next release of code-server should be out soon, and will include this fix.
Fixes #7089
On Windows, ESM loader only accept a valid
file://URLs when it's a absolute path.So add
file://prefix and replace\to '/' to make it a valid URL.