-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Update VS Code 1.95 #7059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VS Code 1.95 #7059
Conversation
6146abe to
52b1aaa
Compare
Trying to see if this resolves the gcc error.
52b1aaa to
f248926
Compare
With the switch to esm, this require is now failing. fs is already imported, so we can just use it anyway. Fixes #7056.
bcpeinhardt
commented
Nov 1, 2024
It got merged while I was reviewing 💀 My only comment was gonna be "so many hashes" haha.
* Update Code to 1.95.1 * Update Node to 20.18.0 * Update build.yaml to use Ubuntu 22.04 This is to resolve a gcc error. Might have to address the release step later as well. * Fix --stdin-to-clipboard With the switch to esm, the fs require is failing. fs is already imported, so we can just use it anyway. * Fix mangled exports * Update CSP hashes
bcpeinhardt
commented
Nov 1, 2024
Also funny that minification respects the export alias.
My bad did not realize you were reviewing!! I will need to get used to not just wild-west merging here lol
Also funny that minification respects the export alias.
Haha yeah, honestly a relief because otherwise we would have to do some crazy things like import it as 6ドルF or whatever name it choose, or dig into the build process and see if we can change the behavior.
Ping @code-asher: code-server-4.95.1-rc.1-linux-amd64.tar.gz with Code 1.95.1 is deployed at https://coder.jupyter.b-data.ch.
- Issue Installing extensions at system level (user:
root, built-in location) throws an error #7042 still persists - Rendering of Nerd Font's glyphs and symbols seem to work properly now
Ping @code-asher: code-server-4.95.1-rc.2-linux-amd64.tar.gz with Code 1.95.1 is deployed at https://coder.jupyter.b-data.ch.
Functionality [modified by patches] tested and found to work:
- base-path
- cli-window-open
- local-storage
- marketplace
- proxy-url
- service-worker
- web view
Workspaces and Jupyter Notebooks also work fine:
ms-toolsai.jupyter@2024100ms-python.python@2024180
code-server v4.95.1-rc.2 also resolves issue #7042.
Unofficial and untested Linux/RISC-V 64-bit (linux/riscv64) and Linux/Power 64-bit (linux/ppc64le) release assets are available at https://gitlab.b-data.ch/coder/code-server/-/releases/v4.95.1.
* Update Code to 1.95.1 * Update Node to 20.18.0 * Update build.yaml to use Ubuntu 22.04 This is to resolve a gcc error. Might have to address the release step later as well. * Fix --stdin-to-clipboard With the switch to esm, the fs require is failing. fs is already imported, so we can just use it anyway. * Fix mangled exports * Update CSP hashes
Uh oh!
There was an error while loading. Please reload this page.
Closes #7052
Fixes #7056.