-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Update VS Code to 1.92.1 #6941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update VS Code to 1.92.1 #6941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@code-asher
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
2 times, most recently
from
August 12, 2024 22:38
fe50409 to
6bac345
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #6941 +/- ## ======================================= Coverage ? 72.62% ======================================= Files ? 31 Lines ? 1903 Branches ? 411 ======================================= Hits ? 1382 Misses ? 441 Partials ? 80
Continue to review full report in Codecov by Sentry.
|
@code-asher
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
from
August 13, 2024 08:27
e14e628 to
56460cb
Compare
It looks like the bootstrap files are now bundled so we can no longer require them. We could make them included again, but maybe it is better to go through the main entrypoint anyway because it includes some nls stuff which is maybe necessary. This also fixes what looks like a bug where we could create two servers if two requests came in. I am not sure what the practical consequences of that would be, but it will no longer do that.
Unfortunately, VS Code will not load with this. It seems to be because
`this` is being used in static properties, and it becomes `void 0` for
some reason under the es2020 target. For example:
static PREFIX_BY_CATEGORY = `${this.PREFIX}${this.SCOPE_PREFIX}`;
becomes
AbstractGotoSymbolQuickAccessProvider.PREFIX_BY_CATEGORY = `${(void 0).PREFIX}${(void 0).SCOPE_PREFIX}`;
Which, obviously, will not work.
Older versions of Safari (and maybe other browsers) are likely affected.
@code-asher
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
5 times, most recently
from
August 16, 2024 01:48
6a9bd85 to
fc4a977
Compare
@code-asher
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
from
August 16, 2024 01:53
fc4a977 to
cf141c3
Compare
I think maybe because of the dropped es2020 patch that Webkit is now failing because it is too old.
I am not sure what is going on but some tests on Webkit are timing out and it seems the page is loaded but something is still trying to download. Not good either way, but for now trying to at least get the tests passing.
yay
code-server-4.92.2-rc.1-linux-amd64.tar.gz with Code 1.92.2 is deployed at https://coder.jupyter.b-data.ch.
Functionality [modified by patches] tested and found to work:
- base-path
- cli-window-open
- local-storage
- marketplace
- proxy-url
- service-worker
- web view
Workspaces and Jupyter Notebooks also work fine:
ms-toolsai.jupyter@202470ms-python.python@2024年12月3日
Huzzah thank you for testing!
yiliang114
pushed a commit
to yiliang114/code-server
that referenced
this pull request
Jan 23, 2025
* Update VS Code to 1.92.2
* Use server-main.js to load VS Code
It looks like the bootstrap files are now bundled so we can no longer
require them. We could make them included again, but maybe it is better
to go through the main entrypoint anyway because it includes some nls
stuff which is maybe necessary.
This also fixes what looks like a bug where we could create two servers
if two requests came in. I am not sure what the practical consequences
of that would be, but it will no longer do that.
* Drop es2020 patch
Unfortunately, VS Code will not load with this. It seems to be because
`this` is being used in static properties, and it becomes `void 0` for
some reason under the es2020 target. For example:
static PREFIX_BY_CATEGORY = `${this.PREFIX}${this.SCOPE_PREFIX}`;
becomes
AbstractGotoSymbolQuickAccessProvider.PREFIX_BY_CATEGORY = `${(void 0).PREFIX}${(void 0).SCOPE_PREFIX}`;
Which, obviously, will not work.
Older versions of Safari (and maybe other browsers) are likely affected.
* Fix display language
* Update Playwright
I think maybe because of the dropped es2020 patch that Webkit is now
failing because it is too old.
* Do not wait for networkidle in e2e tests
I am not sure what is going on but some tests on Webkit are timing out
and it seems the page is loaded but something is still trying to
download. Not good, but for now try to at least get the tests passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Closes #6920
(削除) When building locally, bootstrap-node.js was missing...not sure what is going on there. (削除ここまで)Edit: Looks like the files are bundled now (intoserver-main.js). We could unbundle them again but I opted to call intoserver-main.js(took a small amount patching) since it also seems to do some nls stuff which is maybe important. Also it handles all that VS Code-specific environment variable stuff we were copying before.The es2020 patch does not work. It results in invalid code. Not sure if this is a bug with whatever is doing the transpilation (tsc?) but unfortunately I had to remove it.
(削除) Still need to figure out what to do about the language stuff. (削除ここまで)(削除) I am going to see if our patch is still necessary. (削除ここまで)(削除) Edit: It is, but something about it does not quite work. (削除ここまで)Edit 2: Figured it out, looks like the browser needs a file that sets translations into a global so I am now generating that file locally since we cannot use Microsoft's CDN to pull down translations like how they have it set up.(削除) Also need to look into the proxy URI test failing. (削除ここまで)A flake? Works fine locally.