Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update Node to 20.12.1 #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
code-asher wants to merge 3 commits into main from asher/node-20.12.1
Closed

Update Node to 20.12.1 #6833

code-asher wants to merge 3 commits into main from asher/node-20.12.1

Conversation

Copy link
Member

@code-asher code-asher commented Jun 10, 2024
edited
Loading

Still trying to figure out a failure to connect the first time that reproduces consistently for me.

@code-asher code-asher requested a review from a team as a code owner June 10, 2024 18:47
The watcher seems to not be catching this...unsure if it is a bug yet.
Seems the verbiage has changed.
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0c802ba). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@
## main #6833 +/- ##
=======================================
 Coverage ? 72.77% 
=======================================
 Files ? 31 
 Lines ? 1899 
 Branches ? 410 
=======================================
 Hits ? 1382 
 Misses ? 437 
 Partials ? 80 

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c802ba...4e7def2. Read the comment docs.

Copy link
Member Author

code-asher commented Jun 11, 2024
edited
Loading

I think I finally narrowed the issue down. Seems to have something to do with the display language patch. Experimenting with whether it can be removed or fixed, but this PR is not necessary.

@code-asher code-asher deleted the asher/node-20.12.1 branch July 9, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /