-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Added Password updates to the self hosted index.md #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kirintwn
kirintwn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Sergio Moura <sergio@moura.ca>
Fix Triple ‘s
Closes #548
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIxed those issues. Sorry it took so long, life got in the way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a newline after this codeblock if there's one above it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version and PASSWORD should be in backticks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-e should be in backticks, and this line should end in a fullstop or colon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a codeblock instead of just backticks since it's a long command.
I no longer have time to fix these and I’ve stopped following the project. Closing pull request.
Uh oh!
There was an error while loading. Please reload this page.
Added Password updates to the self hosted index.md. See issue #548 for the documentation. Resolves #624 .
Describe in detail the problem you had and how this PR fixes it
Inadequate documentation of the environment variable change in 1.903-vsc1.33.1.
Is there an open issue you can link to?
#624 and #417