change scope to subpath root instead of domain root so PWA will be installable on subpath #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tobycm wants to merge 1 commit into coder:main from tobycm:main

Closed

change scope to subpath root instead of domain root so PWA will be installable on subpath #5920

tobycm wants to merge 1 commit into coder:main from tobycm:main

Conversation

tobycm

Copy link

Contributor

@tobycm tobycm commented Dec 24, 2022 •

edited

Loading

Fixes #5922

@tobycm


 change scope to subpath root instead of domain root so service worker...

c83053b

... will work on subpath

@tobycm tobycm requested a review from a team as a code owner

December 24, 2022 22:49

@jsjoeio

Copy link

Contributor

jsjoeio commented Jan 3, 2023

Thank you for doing this! Since we don't have e2e tests for this patch, what is your proposed testing plan?

cc @code-asher - mind helping review?

@code-asher

Copy link

Member

code-asher commented Jan 3, 2023 •

edited

Loading

I might be missing something. This seems to do the opposite of the PR title?

Before changeset: domain.tld/a/b/c/code/ would register at ./ which is domain.tld/a/b/c/code/ (register on subpath root)
After changeset: domain.tld/a/b/c/code would register at / which is domain.tld (register on domain root)

@tobycm tobycm changed the title ~~(削除) change scope to subpath root instead of domain root so service worker will work on subpath (削除ここまで)~~ (追記) change scope to subpath root instead of domain root so PWA will be installable on subpath (追記ここまで)

Jan 3, 2023

@tobycm

Copy link

Contributor Author