Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: update download artifacts in release #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 2 commits into main from jsjoeio/fix-download-artifact
Dec 12, 2022

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Dec 6, 2022 •
edited
Loading

A while back, @code-asher and I discussed improving the "Download artifacts" step in the release.yaml workflow.

These changes make it more "sturdy" because we now fail if no artifact found in the latest completed build.yaml workflow.

Pros

  • ensures the latest workflow must have the artifact and be completed
  • fails if artifacts missing

Cons

  • means doing a release might be slower because you have to wait for their to be a completed workflow

code-asher reacted with thumbs up emoji
Comment on lines +303 to +304
check_artifacts: false
if_no_artifact_found: fail
Copy link
Contributor Author

@jsjoeio jsjoeio Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the defaults but I opted to be explicit for these reasons:

  • won't break if defaults change
  • maintainers don't have to go to docs to see defaults because we're explicit here

@jsjoeio jsjoeio self-assigned this Dec 6, 2022
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Dec 6, 2022
@jsjoeio jsjoeio added this to the December 2022 milestone Dec 6, 2022
@jsjoeio jsjoeio marked this pull request as ready for review December 6, 2022 21:43
@jsjoeio jsjoeio requested a review from a team as a code owner December 6, 2022 21:43
@jsjoeio jsjoeio temporarily deployed to npm December 6, 2022 21:50 Inactive
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5841!

  • Last publish status: success
  • Commit: 4643dd5

To install in a local project, run:

npm install @coder/code-server-pr@5841

To install globally, run:

npm install -g @coder/code-server-pr@5841

Copy link

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Merging #5841 (4643dd5) into main (ac6b5bd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph 

@@ Coverage Diff @@
## main #5841 +/- ##
=======================================
 Coverage 74.94% 74.94% 
=======================================
 Files 30 30 
 Lines 1688 1688 
 Branches 371 371 
=======================================
 Hits 1265 1265 
 Misses 361 361 
 Partials 62 62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac6b5bd...4643dd5. Read the comment docs.

@jsjoeio jsjoeio enabled auto-merge (squash) December 12, 2022 17:35
@jsjoeio jsjoeio temporarily deployed to npm December 12, 2022 17:37 — with GitHub Actions Inactive
@jsjoeio jsjoeio merged commit 48588ee into main Dec 12, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-download-artifact branch December 12, 2022 17:47
@jsjoeio jsjoeio modified the milestones: December 2022, 4.9.1 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
chore Related to maintenance or clean up
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /