Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore(deps): update prettier and eslint #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 6 commits into main from jsjoeio/update-deps
Oct 25, 2022
Merged

chore(deps): update prettier and eslint #5700

jsjoeio merged 6 commits into main from jsjoeio/update-deps
Oct 25, 2022

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Oct 24, 2022 •
edited
Loading

Description

Spoke to @code-asher offline who suggested updating our dependencies to avoid the minimatch resolution. Ran yarn _audit locally and all looks good!

Changes

  • chore(deps): update eslint/prettier deps
  • refactor(cli): only import load from js-yaml
  • chore(deps): remove minimatch resolution

@jsjoeio jsjoeio changed the title (削除) jsjoeio/update deps (削除ここまで) (追記) chore(deps): update prettier and eslint (追記ここまで) Oct 24, 2022
@jsjoeio jsjoeio self-assigned this Oct 24, 2022
@jsjoeio jsjoeio added the dependencies Pull requests that update a dependency file label Oct 24, 2022
@jsjoeio jsjoeio marked this pull request as ready for review October 24, 2022 21:13
@jsjoeio jsjoeio requested a review from a team as a code owner October 24, 2022 21:13
import { field, Level, logger } from "@coder/logger"
import { promises as fs } from "fs"
import yaml from "js-yaml"
import {load} from "js-yaml"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint caught this

@jsjoeio jsjoeio temporarily deployed to npm October 24, 2022 21:20 Inactive
Copy link

codecov bot commented Oct 24, 2022 •
edited
Loading

Codecov Report

Merging #5700 (058f575) into main (1134ee1) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph 

@@ Coverage Diff @@
## main #5700 +/- ##
=======================================
 Coverage 72.61% 72.61% 
=======================================
 Files 30 30 
 Lines 1680 1680 
 Branches 368 368 
=======================================
 Hits 1220 1220 
 Misses 397 397 
 Partials 63 63
Impacted Files Coverage Δ
src/node/cli.ts 91.66% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1134ee1...058f575. Read the comment docs.

Copy link

github-actions bot commented Oct 24, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5700!

  • Last publish status: success
  • Commit: c6012ea

To install in a local project, run:

npm install @coder/code-server-pr@5700

To install globally, run:

npm install -g @coder/code-server-pr@5700

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@jsjoeio jsjoeio enabled auto-merge (squash) October 25, 2022 16:11
@jsjoeio jsjoeio temporarily deployed to npm October 25, 2022 16:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /