Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix potential typo for "installing with npm" #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 1 commit into coder:main from Merith-TK:patch-2
Oct 10, 2022
Merged

fix potential typo for "installing with npm" #5630

jsjoeio merged 1 commit into coder:main from Merith-TK:patch-2
Oct 10, 2022

Conversation

Copy link
Contributor

@Merith-TK Merith-TK commented Oct 8, 2022

the link for installing with NPM on line 103 was written as

[installing with npm]./npm.md [installing with npm][./npm.md](./npm.md)
I fixed it to look like
installing with npm [installing with npm](./npm.md)

the link for installing with NPM on line 103 was written as
[installing with npm][./npm.md](./npm.md) `[installing with npm][./npm.md](./npm.md)`
I fixed it to look like
[installing with npm](./npm.md) `[installing with npm](./npm.md)`
@Merith-TK Merith-TK requested a review from a team as a code owner October 8, 2022 18:21
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jsjoeio jsjoeio self-assigned this Oct 10, 2022
@jsjoeio jsjoeio added this to the October 2022 milestone Oct 10, 2022
@jsjoeio jsjoeio enabled auto-merge (squash) October 10, 2022 17:37
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #5630 (4f08786) into main (b2f043a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@
## main #5630 +/- ##
=======================================
 Coverage 72.52% 72.52% 
=======================================
 Files 30 30 
 Lines 1678 1678 
 Branches 366 366 
=======================================
 Hits 1217 1217 
 Misses 398 398 
 Partials 63 63 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f043a...4f08786. Read the comment docs.

@jsjoeio jsjoeio merged commit ba68656 into coder:main Oct 10, 2022
@jsjoeio jsjoeio modified the milestones: October 2022, 4.8.0 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
None yet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /