-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Set RPM Upgrade Flag #5588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set RPM Upgrade Flag #5588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a great improvement to me! 🙌🏼 Thank you!
Let's get 👍🏼 from @code-asher too then we can merge.
Codecov Report
Merging #5588 (8048339) into main (3256157) will not change coverage.
The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@ ## main #5588 +/- ## ======================================= Coverage 72.44% 72.44% ======================================= Files 30 30 Lines 1673 1673 Branches 366 366 ======================================= Hits 1212 1212 Misses 398 398 Partials 63 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 3256157...8048339. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out and it worked perfectly. 👍
Uh oh!
There was an error while loading. Please reload this page.
Fixes #5383, RPM installs should use the -U flag instead of -i because -U will upgrade instead of failing if code-server is already installed.