-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat: add release workflow #5560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ code-server docs for PR #5560 is ready! It will be updated on every commit.
- Host: https://coder.com/docs/code-server/783c6d4
- Last deploy status: success
- Commit: 18d02d6
- Workflow status: https://github.com/coder/code-server/actions/runs/3068723689
Codecov Report
Merging #5560 (18d02d6) into main (7ecfb95) will not change coverage.
The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@ ## main #5560 +/- ## ======================================= Coverage 72.44% 72.44% ======================================= Files 30 30 Lines 1673 1673 Branches 366 366 ======================================= Hits 1212 1212 Misses 398 398 Partials 63 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 7ecfb95...18d02d6. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to test this since I don't have Discussions on my fork (not sure if possible). I don't think this should cause any issue though 🤞🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided for the first version of this to not add on new tags but we can add that in next version. Happy to be convinced to add it here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
.github/workflows/release.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove body_path since we will just overwrite this when copying from the changelog right? I wonder if we can somehow get fancy and automatically extract the last block from the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's true. I'll delete release-notes.txt too since it's already in the changelog.
I wonder if we can somehow get fancy and automatically extract the last block from the changelog.
Haha that would be awesome! Probably some script step before this one that parses CHANGELOG -> grabs relevant block -> outputs to file -> we use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better already!
.github/workflows/release.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually do we need the branch? We could just use whatever artifacts are on the branch we set the workflow to target when dispatching it I think? Normally we would set it to main but this would let us release off different branches too if for some reason we needed to do that (like if we needed to backport a fix).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess not! That's a good point so I guess I'll change this to ${{ github.ref }}
Uh oh!
There was an error while loading. Please reload this page.
Description
This PR is Part 1 / ? of the release workflow refactor. This adds a new workflow called
release.yamlwhich creates a draft GitHub release and uploads artifacts frommain. It assumes you've bumped the version in thepackage.jsonalready.Changes
Testing Plan
I tested this on my fork and was able to use it successfully.
Run: https://github.com/jsjoeio/code-server/actions/runs/3064111088
image
Related to #2817