Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: move security workflows #5553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 2 commits into main from jsjoeio/move-security-workflows
Sep 14, 2022
Merged

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Sep 13, 2022
edited
Loading

  • refactor: move security jobs to security.yaml
  • fixup! refactor: move security jobs to security.yaml

Fixes #4960

@jsjoeio jsjoeio self-assigned this Sep 13, 2022
@jsjoeio jsjoeio added ci Issues related to ci chore Related to maintenance or clean up labels Sep 13, 2022
Comment on lines +6 to +8
pull_request:
# The branches below must be a subset of the branches above
branches: [main]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to run it on this right? But not make it required?

Copy link
Member

@code-asher code-asher Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that probably makes sense in case the PR introduces new security vulnerabilities otherwise they would not get caught until the next cron.

jsjoeio reacted with thumbs up emoji
@jsjoeio jsjoeio changed the title (削除) jsjoeio/move security workflows (削除ここまで) (追記) chore: move security workflows (追記ここまで) Sep 13, 2022
@jsjoeio jsjoeio marked this pull request as ready for review September 13, 2022 19:01
@jsjoeio jsjoeio requested a review from a team as a code owner September 13, 2022 19:01
@jsjoeio jsjoeio temporarily deployed to npm September 13, 2022 19:03 Inactive
Copy link

✨ code-server dev build published to npm for PR #5553!

  • Last publish status: success
  • Commit: af44b73

To install in a local project, run:

npm install @coder/code-server-pr@5553

To install globally, run:

npm install -g @coder/code-server-pr@5553

Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #5553 (af44b73) into main (b440054) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@
## main #5553 +/- ##
=======================================
 Coverage 72.44% 72.44% 
=======================================
 Files 30 30 
 Lines 1673 1673 
 Branches 366 366 
=======================================
 Hits 1212 1212 
 Misses 398 398 
 Partials 63 63 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b440054...af44b73. Read the comment docs.

@jsjoeio jsjoeio merged commit 309a3b2 into main Sep 14, 2022
@jsjoeio jsjoeio deleted the jsjoeio/move-security-workflows branch September 14, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
chore Related to maintenance or clean up ci Issues related to ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore]: Move security vulnerabilities workflow out of ci.yaml

AltStyle によって変換されたページ (->オリジナル) /