-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Fix deb install instructions: ${VERSION}_foo #5542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The install instructions weren't copy-pastable: `$VERSION_foo` is the same as `${VERSION_foo}`, not `${VERSION}_foo`.
```sh
$ VERSION=4.6.1
$ curl -fOL https://github.com/coder/code-server/releases/download/v$VERSION/code-server_$VERSION_amd64.deb
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 9 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 404
$ echo curl -fOL https://github.com/coder/code-server/releases/download/v$VERSION/code-server_$VERSION_amd64.deb
curl -fOL https://github.com/coder/code-server/releases/download/v4.6.1/code-server_.deb
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice quality of life improvement. Thank you!
Codecov Report
Merging #5542 (1e6d7c7) into main (64822d0) will not change coverage.
The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@ ## main #5542 +/- ## ======================================= Coverage 72.44% 72.44% ======================================= Files 30 30 Lines 1673 1673 Branches 366 366 ======================================= Hits 1212 1212 Misses 398 398 Partials 63 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 64822d0...1e6d7c7. Read the comment docs.
The install instructions weren't copy-pastable:
$VERSION_foois the same as${VERSION_foo}, not${VERSION}_foo.Fixes #